Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plotly figures do not show in colab notebooks #1165

Closed
LeonieFreisinger opened this issue Feb 20, 2023 · 10 comments
Closed

plotly figures do not show in colab notebooks #1165

LeonieFreisinger opened this issue Feb 20, 2023 · 10 comments
Assignees
Labels
good first issue Good for newcomers priority:P2 Medium priority type:bug Something isn't working

Comments

@LeonieFreisinger
Copy link
Collaborator

Description

Currently figures are not displayed at all in google colab notebooks, when using the plotly backend. You can see this problem, when running [this notebook] in (https://github.com/ourownstory/neural_prophet/blob/main/tutorials/feature-use/plotly.ipynb) colab.
Colab introduced the following fix for this problem, see this discussion:

from google.colab import output
output.enable_custom_widget_manager()

Required action
Check for all NeuralProphet tutorial notebooks if the plotly plotting_backend is used and import the introduced fix to display the figures properly.

@LeonieFreisinger LeonieFreisinger added type:bug Something isn't working good first issue Good for newcomers labels Feb 20, 2023
@github-project-automation github-project-automation bot moved this to Needs triage in Bug triage Feb 20, 2023
@LeonieFreisinger LeonieFreisinger moved this from Needs triage to Low priority in Bug triage Feb 20, 2023
@SimonWittner
Copy link
Collaborator

Hey, can I work on this?

@LeonieFreisinger
Copy link
Collaborator Author

@SimonWittner Thanks for picking that one up. Let me know if you have any questions.

@noxan noxan added the priority:P2 Medium priority label Feb 24, 2023
@vijaybirju
Copy link

It is has been 3 weeks already passed. can I make PR. it just takes my few minutes

@leoniewgnr
Copy link
Collaborator

@SimonWittner are you still working on this because if not @vijaybirju could take over

@SimonWittner
Copy link
Collaborator

It was unclear to me, whether this issue is still up-to-date since bigger changes regarding the plotting-backend are planned. I checked with @LeonieFreisinger and will fix this issue.

@vijaybirju
Copy link

It was unclear to me, whether this issue is still up-to-date since bigger changes regarding the plotting-backend are planned. I checked with @LeonieFreisinger and will fix this issue.

Simon i am making pull request

@LeonieFreisinger
Copy link
Collaborator Author

@vijaybirju Thanks for your interest! Since @SimonWittner is still assigned to the issue, let´s have him continue on the issue.
@vijaybirju In case you are looking for a good first issue, how about you take over #1258 ?

@vijaybirju
Copy link

@vijaybirju Thanks for your interest! Since @SimonWittner is still assigned to the issue, let´s have him continue on the issue. @vijaybirju In case you are looking for a good first issue, how about you take over #1258 ?

sorry it was my bad I thought he different person from Assignees.

@vijaybirju
Copy link

It was unclear to me, whether this issue is still up-to-date since bigger changes regarding the plotting-backend are planned. I checked with @LeonieFreisinger and will fix this issue.

sorry, Simon

@leoniewgnr
Copy link
Collaborator

closed as handled in #1309

@github-project-automation github-project-automation bot moved this from Low priority to Closed in Bug triage Apr 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers priority:P2 Medium priority type:bug Something isn't working
Projects
Status: Closed
Development

No branches or pull requests

5 participants