Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the ability to allow a delegator to cast a vote for a specific address #103

Open
MrKevinOConnell opened this issue May 27, 2023 · 0 comments

Comments

@MrKevinOConnell
Copy link

Currently, in Governor.sol the _castVote function takes in the following:

function _castVote(
    bytes32 _proposalId,
    address _voter,
    uint256 _support,
    string memory _reason
) internal returns (uint256)

This covers:

1.) A user who doesn't have a token (reverts)
2.) A user who has a token
3.) A user who is delegated tokens

however: what if a delegated voter (ex. an autonomous agent) wanted to make a vote only for a specific token holder? This doesn't cover that case.

It would be good IMO to add another param that is used to get the votes originally belonging to someone. So say Tom delegated 5 votes to an AI agent, and Sally also gave 5 votes, the ai can vote separately for each person. There would also have to be a check to make sure that the given address has delegated to the voter (ai agent)

In the case the param is 0x000... do the same logic that we have now.

Let me know if there are any questions, or if there are better approaches to this. Really excited about everything Nouns and would love to do this!

@MrKevinOConnell MrKevinOConnell changed the title Add the ability to cast a vote for a specific address Add the ability to allow a delegator to cast a vote for a specific address May 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant