Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plans for ROS2? #50

Closed
Grisly00 opened this issue Jan 19, 2023 · 10 comments
Closed

Plans for ROS2? #50

Grisly00 opened this issue Jan 19, 2023 · 10 comments
Assignees
Labels
question Further information is requested

Comments

@Grisly00
Copy link

Grisly00 commented Jan 19, 2023

Hi everyone,

I would like to revisit this issue ouster-lidar/ouster_example#205 from two years ago to get some information on you plans about ROS2.
More and more applications and drivers are shifting to ROS2 which makes it increasingly frustrating to work with ROS1 packages.

I am aware that there is a ROS2 driver by the community (https://github.com/ros-drivers/ros2_ouster_drivers), but it still lacks some key features such as the Dual Return mode.

From Ouster distribution we got the information, that a official ROS2 driver is in the works and could potentially be released in the first half of 2023. Here on github it more seems like you try to cooperate with the community driver.

Could elaborate a bit on what to expect from the upcoming months as a user. It is very time consuming to implement things like ROS bridge or switching Distros, so this could help us a lot with planing on where to put resources.

Thanks in advance!

@Samahu Samahu self-assigned this Jan 19, 2023
@Samahu Samahu added enhancement New feature or request question Further information is requested and removed enhancement New feature or request labels Jan 19, 2023
@Samahu
Copy link
Contributor

Samahu commented Jan 19, 2023

@Grisly00, I understand your frustration. We should have an early prototype implementation of ROS2 driver this month.

@Grisly00
Copy link
Author

Happy to hear you are working on that!
We will be looking forward to it, thank you for your fast answer!

@Samahu Samahu mentioned this issue Jan 25, 2023
@mvancleaver
Copy link

+1 to this.

Our team is migrating to ROS2 and an official driver would be great

@Samahu
Copy link
Contributor

Samahu commented Jan 27, 2023

@mvancleaver Thanks for the feedback, keep an eye 👀 on #51 (which is still a work in progress).

@DrShIkIgAmy
Copy link

DrShIkIgAmy commented Feb 3, 2023

My team and I has already implemented ros2 pkg for ouster driver. And to keep sync with official repo, we could gladly put it in corresponding branch of ouster-ros repo. As far as I know, my colleague @ShepelIlya has already offered it. So @Samahu, what do you think about that?

@ShepelIlya
Copy link
Contributor

My team and I has already implemented ros2 pkg for ouster driver. And to keep sync with official repo, we could gladly put it in corresponding branch of ouster-ros repo. As far as I know, my colleague @ShepelIlya has already offered it. So @Samahu, what do you think about that?

Yeeah +1 to this. We are ready to share our code for ROS2. It have been tested already on our robot with 2 OS1-32.

@Samahu
Copy link
Contributor

Samahu commented Feb 3, 2023

@DrShIkIgAmy @ShepelIlya thanks so much for offering the support on this, and just to let you know I am always in favor of accepting any beneficial or valuable contributions, however, we do have certain requirements of the ros2 diver from multiple customers/users that we need to fulfill.

Good news though, I should be wrapping up the #51 PR today and I expect it to be merged early next week once reviews are completed.

@Samahu
Copy link
Contributor

Samahu commented Feb 13, 2023

Just as an update, the linked PR is still in review, I expect that it would be merged this week.

@hodnajit
Copy link

Just as an update, the linked PR is still in review, I expect it would be merged this week.

Oooh looking forward to try that one :)

@Samahu
Copy link
Contributor

Samahu commented Feb 21, 2023

We have completed our of merge of #51 PR, this is the minimal viable product and the driver is released as a beta version. More work and improvements is planned towards the ros2 driver which we will deliver over the next month.
Please give it a try when you have the time:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

6 participants