Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow location_id = None for PrevalenceAllLineagesByLocationHandler #67

Open
flaneuse opened this issue Dec 20, 2022 · 0 comments
Open
Assignees
Labels
good first issue Good for newcomers guru

Comments

@flaneuse
Copy link
Contributor

flaneuse commented Dec 20, 2022

Currently, this query fails, since no location_id is specified:

https://api.outbreak.info/genomics/prevalence-by-location-all-lineages?other_threshold=0.03&nday_threshold=5&ndays=60

(The query only works if you set location_id, like: https://api.outbreak.info/genomics/prevalence-by-location-all-lineages?location_id=USA_US-CA&other_threshold=0.03&nday_threshold=5&ndays=60)

We would like to have the PrevalenceAllLineagesByLocationHandler to be able to accept arguments where the location_id is not specified. In that case, the aggregated data returned will be for the all data (e.g. Global location), without a location_id filter.

I believe it should be as simple as adding a check if location_id exists, like in CumulativePrevalenceByLocationHandler

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers guru
Projects
None yet
Development

No branches or pull requests

2 participants