You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
As the post in dgraph-io/ristretto#108 tried to highlight, the XOR with the same seed for each given row doesn't accomplish what the author of the change had expected. So you don't get the benefit of four rows. Might as well just make the structure one row. Of course four rows was the original design of Ben Manes for good reason, so reverting to the earlier approach or coming up with a different way to pull a different count based on the row index and the hash is warranted.
Here's where I offered a fix dgraph-io/ristretto#326
and Ben chimed in that while it looked reasonable the go code could use more eyes and anyway, Vitess was moving to another derivation of his work.
The text was updated successfully, but these errors were encountered:
ristretto/sketch.go
Line 67 in a9bee01
As the post in dgraph-io/ristretto#108 tried to highlight, the XOR with the same seed for each given row doesn't accomplish what the author of the change had expected. So you don't get the benefit of four rows. Might as well just make the structure one row. Of course four rows was the original design of Ben Manes for good reason, so reverting to the earlier approach or coming up with a different way to pull a different count based on the row index and the hash is warranted.
Here's where I offered a fix dgraph-io/ristretto#326
and Ben chimed in that while it looked reasonable the go code could use more eyes and anyway, Vitess was moving to another derivation of his work.
The text was updated successfully, but these errors were encountered: