Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing the color of the focused tab of an inactive container ? #71

Open
StitiFatah opened this issue Feb 14, 2024 · 2 comments
Open

Comments

@StitiFatah
Copy link

StitiFatah commented Feb 14, 2024

In i3 in addition to client.focused and client.unfocused there is also client.focused_inactive which is as per the docs : A client which is the focused one of its container, but it does not have the focus at the moment.

Is it possible to target those with hy3 ? My goal would be to have the focused tab of the inactive container be the same color as unfocused tabs.

All I see in hy3's docs is : col.active and col.inactive

Not a deal breaker tho since one can still rely on windows (and not tabs) colors and having active = focused_inactive is essential if one wants to use hy3:movefocus, {direction}, visible, just a nice option to have imo.

Thanks in advance.

@outfoxxed
Copy link
Owner

In i3 in addition to client.focused and client.unfocused there is also client.focused_inactive which is as per the docs : A client which is the focused one of its container, but it does not have the focus at the moment.

IIRC this was initially planned but it wasn't very easy to hook the right code to do it like it is for selection, as the color needs to be changed. If you want it I would advise getting some kind of hook for border color into hyprland.

My goal would be to have the focused tab of the inactive container be the same color as unfocused tabs.

If you mean the tab as in the rendered tab indicator above the window this would be an easy patch. If you want to give it a go, I'd add a config variable for the unfocused/selected state and add a case for it in Hy3TabBarEntry::prepareTexture (TabGroup.cpp).

I may get around to it eventually myself but hy3 is currently not my main project, I just keep it compatible with hyprland at the moment, as I have limited time.

@StitiFatah
Copy link
Author

If you mean the tab as in the rendered tab indicator above the window this would be an easy patch. If you want to give it a go, I'd add a config variable for the unfocused/selected state and add a case for it in Hy3TabBarEntry::prepareTexture (TabGroup.cpp).

Yes that's what I meant but I'm sadly not familiar with c++

I may get around to it eventually myself but hy3 is currently not my main project, I just keep it compatible with hyprland at the moment, as I have limited time.

Np that's just a minor inconvenience mainly coming from being accustomed to a specific workflow on i3, it's already good enough nonetheless and the only reason I can use hyprland, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants