Bun throws error when copying file to a folder that does not exist

[birkskyum]

What version of Bun is running?

1.1.10-canary.1+cc0bce62e

What platform is your computer?

Darwin 23.4.0 arm64 arm

What steps can reproduce the bug?

I experience that I can make a clean basic example (bun create solid), dump a few files in the public folder, like .glb 3d models, and then the bun --bun run build command will break with:

 ERROR  { [ENOENT: No such file or directory]                                                                                                            9:06:21 AM
  code: 'ENOENT',
  path:
   '/Users/admin/repos/bun-kitchensink/solid/wefwef/public/3dmodels/giantherb/giantherb.glb',
  syscall: 'copyfile',
  errno: -2 } 



 ERROR  No such file or directory                                                                                                                        9:06:21 AM

error: script "build" exited with code 1

It's worth noting that it's not a requirement to use these files anywhere in the code for this to break

What is the expected behavior?

When running pnpm run build or npm, then the build completes

What do you see instead?

No response

Additional information

Related to

• Support SolidStart #3736

[paulo-assoc]

Confirmed, @birkskyum. I have the same issue (used Bun v1.1.9 on Windows 11):

[ghost]

the error occurs when working with nitropack (vinxi/nitro component). something is wrong with fs.promises.cp(). this happens even if all copies are executed sequentially (for (...) { await ... })

https://github.com/unjs/nitro/blob/61f2079a605fca81b578894edfdbb0c328db12a3/src/build.ts#L87

[sirenkovladd]

Smaller reproduce

import { promises } from 'node:fs';

const src = 'newFile.txt';
const folder = 'folder-not-exist'
const dst = `${folder}/${src}`;

await promises.writeFile(src, 'A'.repeat(131073))

await promises.rm(folder, { recursive: true, force: true })
await promises.cp(src, dst);
console.log('Success')

❯ bun test.js 
ENOENT: No such file or directory
   errno: -2
 syscall: "copyfile"
   path: "newFile.txt"


Bun v1.1.10 (macOS arm64)

❯ node test.js
Success

If this works for you, you can try increasing the repetition value

[birkskyum]

Now that it's much more narrowed down - What would be a more accurate title for this issue?

Any pointers to wether the issue is in .repeat() or in the .writeFile?

[paulo-assoc]

I didn't use .repeat when I got the error (unless SolidStart is using it internally, which I doubt.).

[Huliiiiii]

If folder doesn't exist, cp in node will create folder, but bun won't.

import { promises } from 'node:fs';

const src = 'newFile.txt';
const folder = 'folder-not-exist'
const dst = `${folder}/${src}`;

await promises.writeFile(src, 'A'.repeat(131073))

await promises.rm(folder, { recursive: true, force: true })
await promises.mkdir(folder);
await promises.cp(src, dst);
console.log('Success')

Bun run this => Success

[sirenkovladd]

Bun error occurs if you need to copy a large file to a folder that does not exist
The problem is precisely only in the large file, since everything is fine with small files

[paulo-assoc]

So @birkskyum, new issue title could be, "Bun throws error when copying large file to a folder that does not exist"?

[paulo-assoc]

Thanks to @sirenkovladd for supplying the "smaller reproduce"!

[Huliiiiii]

如果您需要将large文件复制到不存在的文件夹，则会出现 Bun 错误 问题恰恰只出现在大文件中，因为小文件一切正常

await promises.writeFile(src, 'A')

On my computer, this also causes the error, so I don't think the file size is the issue.

[Huliiiiii]

bun/src/js/node/fs.promises.ts

Line 4 in 99b979e

const fs = $zig("node_fs_binding.zig", "createBinding");

bun/src/js/node/fs.promises.ts

Lines 97 to 109 in 99b979e

	// attempt to use the native code version if possible
	// and on MacOS, simple cases of recursive directory trees can be done in a single `clonefile()`
	// using filter and other options uses a lazily loaded js fallback ported from node.js
	function cp(src, dest, options) {
	if (!options) return fs.cp(src, dest);
	if (typeof options !== "object") {
	throw new TypeError("options must be an object");
	}
	if (options.dereference || options.filter || options.preserveTimestamps || options.verbatimSymlinks) {
	return require("../internal/fs/cp")(src, dest, options);
	}
	return fs.cp(src, dest, options.recursive, options.errorOnExist, options.force ?? true, options.mode);
	}

Set any option that makes this function return the js fallback ported from node will make the program succeed.

import { promises } from "node:fs"

const src = "newFile.txt"
const folder = "folder-not-exist"
const dst = `${folder}/${src}`

await promises.writeFile(src, "A")

await promises.rm(folder, { recursive: true, force: true })
await promises.cp(src, dst, { dereference : true })
await promises.rm(folder, { recursive: true, force: true })
await promises.cp(src, dst, { preserveTimestamps: true })
await promises.rm(folder, { recursive: true, force: true })
await promises.cp(src, dst, { verbatimSymlinks: true })
console.log("Success")

So I think the problem is in zig's implementation.

[birkskyum]

Nice find with the repro @Huliiiiii . Seems like some zig expertise is due at this point. cc @paperdave