-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Single Flight server actions - SolidStart (notes example) #12191
Comments
@paulo-assoc - The latest version of the Notes example appear to be working, after fixes on the solid side. It uses a new version of the solid-router/solid-start that has some bugs fixed, so updating will fix the issue with the same version of bun (1.1.18). Let me know if you still see issues. |
@birkskyum I still didn't work: PS C:\Users\paulo\source\repos\solid-bun> bun run --bun dev ➜ Local: http://localhost:3004/ [h3] [unhandled] 1 | export default "native"; 1 | export default "native"; I used Bun 1.1.18. Here is my package,json: { |
@birkskyum It worked for you? |
Yes. A notes version of older versions still break, but not the latest |
@paulo-assoc , it crashes for me again now too with. a new repo... |
@birkskyum I tried it with an update of an existing repo and with a new repo using "bun create solid". Either way it crashes with bun 1.1.18 on Windows. bun run --bun dev ➜ Local: http://localhost:3004/ [h3] [unhandled] 1 | export default "native"; 1 | export default "native"; |
@birkskyum You must have an update I don't have. Thoughts? |
@paulo-assoc , I don't know why it seemed like it worked briefly... must be a fluke, or there could be a race condition involved. |
Thanks, @birkskyum! I want you to know that I appreciate you. |
Any updates, @birkskyum? |
@paulo-assoc , not that I'm aware of. This is what's being worked on right now. The merger of the node:cluster appear to be in progress, so hopefully this will be picked up at some point when the top tickets are resolved. |
Thanks for the update, @birkskyum! |
@paulo-assoc , with the new Bun 1.1.27, this seems to be working. |
Wow! I tested the SolidStart notes app with Bun 1.1.27 on Windows 11 and found no issues. Thanks, @birkskyum! |
@birkskyum Does this mean we can safely use solid start with Bun? Or are there other known issues? |
SolidStart appear to be quite well supported now - i've used it in prod for a while, without this missing feature. There are some auth packages / vitest / http2 things left that aren't in place yet, which could prove problematic - as noted here, but thats the same for everyone. I.e. sveltekit here, and I think the planned crypto rewrite is what ultimately will unlock these tickets - so there's nothing solidstart-specific left to my knowledge. |
@birkskyum I didn't see any mention of this big news in the release notes for Bun 1.1.27. |
@paulo-assoc , i'm also not sure which PR made the difference (best guess is this #13744 ), but I'm glad it works. |
What version of Bun is running?
1.1.17+bb66bba1b
What platform is your computer?
Darwin 23.5.0 arm64 arm
What steps can reproduce the bug?
Create project:
Run:
What is the expected behavior?
New note is saved
What do you see instead?
Internal server error in browser console
Terminal shows:
Additional information
No response
The text was updated successfully, but these errors were encountered: