Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom registry url gets trimmed if trailing forward slash is missing #14017

Open
luciodale opened this issue Sep 18, 2024 · 1 comment
Open
Labels
bug Something isn't working bun install Something that relates to the npm-compatible client

Comments

@luciodale
Copy link

What version of Bun is running?

1.1.26

What platform is your computer?

x64

What steps can reproduce the bug?

Add under ~/ dir a .bunfig.toml file like this:

[install]
registry = { url = "https://www.my-repo/npm-enterprise", token = "..."}

Then:

bun install

What is the expected behavior?

When running bun install, I should see the url used to fetch the libs (react for example) as: https://www.my-repo/npm-enterprise/react

What do you see instead?

I see the url to fetch react as: https://www.my-repo/react

Additional information

Adding a trailing forward slash to the url fixes the problem i.e. https://www.my-repo/npm-enterprise/. Though, I don't think it should be required, as https://www.my-repo/npm-enterprise is a perfectly valid url.

@luciodale luciodale added bug Something isn't working needs triage labels Sep 18, 2024
@Zooce
Copy link

Zooce commented Sep 19, 2024

I'm seeing this as well, but I noticed it with bun outdated which printed no output:

$ bun oudated
bun outdated v1.1.28 (cf4e9cb6)

$

@nektro nektro added bun install Something that relates to the npm-compatible client and removed needs triage labels Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working bun install Something that relates to the npm-compatible client
Projects
None yet
Development

No branches or pull requests

3 participants