Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement node_register_module and some V8:: APIs #3110

Open
Jarred-Sumner opened this issue May 29, 2023 · 8 comments
Open

Implement node_register_module and some V8:: APIs #3110

Jarred-Sumner opened this issue May 29, 2023 · 8 comments
Assignees
Labels
bug Something isn't working node:v8

Comments

@Jarred-Sumner
Copy link
Collaborator

Jarred-Sumner commented May 29, 2023

This is blocking:

These (and others like uWebSocket.js) use the V8 APIs instead of the cross-runtime n-api (which bun already implement)

We can probably look at node-jsc to see how to do this.

@Jarred-Sumner Jarred-Sumner changed the title Implement node_register_module and someV8 APIs Implement node_register_module and some V8:: APIs May 29, 2023
@chriskrogh
Copy link

chriskrogh commented Feb 20, 2024

@Jarred-Sumner @colinhacks would it be possible for @Faire to put a bounty on this? node-canvas is the last holdout for us adopting bun install in our frontend monorepo. bun would save us a lot of time in local dev & CI. #5835 (comment)

(some of our testing deps link node_canvas: mocha, jsdom, jest-environment-jsdom)

@7f8ddd
Copy link
Contributor

7f8ddd commented Feb 20, 2024

@Jarred-Sumner @colinhacks would it be possible for @Faire to put a bounty on this? node-canvas is the last holdout for us adopting bun install in our frontend monorepo. bun would save us a lot of time in local dev & CI. #5835 (comment)

node-canvas already has an NAPI port, you just need to build the latest from the git.
Alternatively, you can use https://github.com/Brooooooklyn/canvas, which is faster and has basically the same API.

@chriskrogh
Copy link

chriskrogh commented Feb 20, 2024

node-canvas already has an NAPI port, you just need to build the latest from the git. Alternatively, you can use https://github.com/Brooooooklyn/canvas, which is faster and has basically the same API.

we don't depend on canvas ourselves. some of our dependencies try to link it during the installation process (mocha, jsdom, jest-environment-jsdom, ...) is there a way to get these dependencies to use the NAPI version?

@AdamSchinzel
Copy link

Any updates when we can expect this to land?

@gerardmarquinarubio
Copy link

node-canvas already has an NAPI port, you just need to build the latest from the git. Alternatively, you can use https://github.com/Brooooooklyn/canvas, which is faster and has basically the same API.

we don't depend on canvas ourselves. some of our dependencies try to link it during the installation process (mocha, jsdom, jest-environment-jsdom, ...) is there a way to get these dependencies to use the NAPI version?

@chriskrogh Yes if you are willing to do some messy postinstall scripting, would be much easier if bun supported some nested overriding but that is also not in the roadmap afaik.

@chriskrogh
Copy link

@Jarred-Sumner gentle bump here. seems like both this issue (and related ones #5835) have been racking up reactions. any plans on adding this to bun sometime soon?

@ignSKRRRTT
Copy link

Please 🙏🏻

@7f8ddd
Copy link
Contributor

7f8ddd commented Jun 15, 2024

@Jarred-Sumner gentle bump here. seems like both this issue (and related ones #5835) have been racking up reactions. any plans on adding this to bun sometime soon?

node-canvas literally works fine. instead of telling Bun to update, tell those mfs to publish a release, because they haven't done that in forever.

@nektro nektro added bug Something isn't working node:v8 labels Sep 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working node:v8
Projects
None yet
Development

No branches or pull requests

8 participants