Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make all builtin node:* or bun:* modules use a variant of CommonJS #3773

Closed
Jarred-Sumner opened this issue Jul 23, 2023 · 1 comment · Fixed by #3814
Closed

Make all builtin node:* or bun:* modules use a variant of CommonJS #3773

Jarred-Sumner opened this issue Jul 23, 2023 · 1 comment · Fixed by #3814

Comments

@Jarred-Sumner
Copy link
Collaborator

It looks like the crash in #3746 is caused by a module evaluation issue with ES Modules. If we switched our node/bun modules to use CommonJS we can lazy load them and also avoid any module evaluation linking issues
@wayjake
Copy link

wayjake commented Jul 23, 2023

@Jarred-Sumner Jarred-Sumner mentioned this issue Jul 24, 2023
Closed
@paperclover paperclover mentioned this issue Jul 26, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rewrite built-in modules to use CommonJS over ESM oven-sh/bun
2 participants
@Jarred-Sumner @wayjake