Bun Fails to Load sodium-native NAPI

[pcfreak30]

What version of Bun is running?

0.7.4

What platform is your computer?

Linux 5.15.0-78-generic x86_64 x86_64

What steps can reproduce the bug?

Use the repo https://github.com/LumeWeb/bun-sodium-native-bug

What is the expected behavior?

The NAPI addon loads successfully and exports all object symbols

What do you see instead?

An empty js object

Additional information

this may be due to one or more API's not implemented, a list i gathered that may/may not be accurate.

• napi_detach_arraybuffer
• napi_get_element
• napi_get_global
• napi_close_handle_scope
• napi_delete_reference
• napi_get_reference_value

[pcfreak30]

This bug still applies on 0.8.0

[pcfreak30]

Also based on #4259, running bun install --build-from-source in sodium-native and the main project does not help, to rule that out.

[xhyrom]

You can remove napi_close_handle_scope from the list, it is implemented unlike other

[pcfreak30]

You can remove napi_close_handle_scope from the list, it is implemented unlike other

done

[pcfreak30]

Based on discord chats, https://github.com/sodium-friends/sodium-native/blob/master/binding.c#L3309C1-L3313C40

we dont handle returning an napi_vaue
only mutating exports

@paperdave

Recording here for reference

[ansarizafar]

Is there any solution?

[pcfreak30]

🤷 I have been waiting, but it seems this bug isn't high on the team's priority list. UDP is also still waiting and has many more people begging for it.