-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sharable dependency version specifiers #4844
Comments
Agree with this. It feels very unnecessary being forced to install "common" packages for a monorepo into every single workspace package. Examples include specific typescript version, eslint, prettier. Packages installed in the root dev/dependencies should be automatically resolvable by all workspace packages. If a package must use a specific version it can be defined in it's respective package.json. This should further lead to individual packages not straying away from the versions used by the entire repo. |
Isn't this resolutions / overrides support ? #1134 |
@Hebilicious no, this is different This PR is really for monorepos. For instance, if I use axios, i want to be able to specify that axios should use version |
Bun could add |
@Hebilicious and how would that work for child package.json? what version specifier would you use for |
You can use anything, incuding |
Solution worksforme But I think consulting the PNPM rfc makes should be done. a lot of thought/effort went into that |
This RFC is quite long, I would suggest you update the description here with more accurate information. There's a subtle difference with overrides/resolutions that is documented here. |
I don't really have much skin in the game. Either solution works, but I think for the JS ecosystem it would be preferable if PNPM and bun were in sync here. That way, switching to bun can be even more of a "drop in replacement" |
I would suggest to recommend only Replacing "anything" is technically correct as it is really just an override, |
Update, this is now implemented in @Jarred-Sumner should bun just "work" here with the same syntax? Hard to tell with the binary bun lockfile |
I'm curious if there is any update on whether or when this might be added. We have had a number of minor bugs recently where we had slight mismatches in dependency versions (e.g. i18next For now, I am planning to pin everything to a particular version across our whole monorepo, but that isn't a sustainable approach. |
Since it's not mentioned, here are the pnpm docs for pnpm catalogs |
I tried set workspace:* and it just does not work because this is only used to mention the sub-repo of monorepo not the used packages |
any news? |
What is the problem this feature would solve?
In a monorepo, it would be cool to specify a single set of package pins at the repo root and those could then just be used throughout the repository instead of needing to be specified in numerous places.
Here is the PNPM RFC for accomplishing this: pnpm/rfcs#1
What is the feature you are proposing to solve the problem?
Sharable package pins accross a monorepo
What alternatives have you considered?
No response
The text was updated successfully, but these errors were encountered: