Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce usage of nighlty features #156

Open
zetanumbers opened this issue Sep 27, 2023 · 3 comments
Open

Reduce usage of nighlty features #156

zetanumbers opened this issue Sep 27, 2023 · 3 comments

Comments

@zetanumbers
Copy link
Contributor

psp/src/panic.rs breaks a lot lately, maybe gate this under a cargo feature and use panic = "abort" by default.

@SK83RJOSH
Copy link
Contributor

This issue should probably be renamed, the issue with panics seems to be some sort of linker change upstream in rust-lld. My general suggestion would be to move to unwinding and figure out what workaround mitigates the underlying issue/isolate what change in rust-lld broke them in the first place.

In lieu of that, panic support should be dropped outright, though I think that would be rather unfortunate.

@zetanumbers
Copy link
Contributor Author

This issue should probably be renamed…

No, don't think it's just about the panics. In general we would want this to reduce severity of future breakages. If we want to focus on a specific aspect, we could open a new issue or PR for that.

@SK83RJOSH
Copy link
Contributor

In general we would want this to reduce severity of future breakages.

Fair enough, though I suppose an effort should be made to enumerate the most fragile things. Ie/ internal features dependencies, and so on.

But yeah I'll probably spin off a separate issue about panics, tried to get discussion going about it on discord, but it seems it's dead in the water for now. 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants