Skip to content

Commit a86e70c

Browse files
ciaranschutteCiaran Schutte
andcommitted
Minor comment updates (#905)
* improve comment * improve comment --------- Co-authored-by: Ciaran Schutte <ciaranschutte@oicr.on.ca>
1 parent 87355bb commit a86e70c

File tree

2 files changed

+8
-3
lines changed

2 files changed

+8
-3
lines changed

modules/server/src/network/resolvers/aggregations.ts

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -103,11 +103,13 @@ const convertFieldsToString = (requestedFields: RequestedFieldsMap) => {
103103
};
104104

105105
/**
106-
* Query string creation
106+
* Creates individual GQL query string for a node.
107+
* Includes aggregation GQL arguments (actual data is provided alongside query, not here)
108+
* Requested fields are converted to GQL style strings
107109
*
108110
* @param documentName
109111
* @param requestedFields
110-
* @returns
112+
* @returns constructed query string
111113
*/
112114
export const createNodeQueryString = (
113115
documentName: string,

modules/server/src/network/resolvers/index.ts

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,9 @@ export type NetworkSearchRoot = {
1212
aggregations: Record<string, unknown>;
1313
};
1414

15+
/*
16+
* Type should match the "Network" GQL type definition arg types
17+
*/
1518
export type NetworkAggregationArgs = {
1619
filters?: object;
1720
aggregations_filter_themselves?: boolean;
@@ -33,7 +36,7 @@ export const createResolvers = (configs: NodeConfig[]) => {
3336
Query: {
3437
network: async (
3538
parent: NetworkSearchRoot,
36-
// type should match gql typedefs
39+
// as mentioned above, type should match gql typedefs
3740
args: NetworkAggregationArgs,
3841
context: unknown,
3942
info: GraphQLResolveInfo,

0 commit comments

Comments
 (0)