Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interpreter: Internal errors are reported as "internal error" but could have displayed the real problem description #444

Closed
lausdahl opened this issue May 7, 2015 · 2 comments
Labels
enhancement Not a bug, but nice to have
Milestone

Comments

@lausdahl
Copy link
Member

lausdahl commented May 7, 2015

The handling of internal errors in the interpreter is not useful since it just displays "internal error" but in many cases it might be e.g. a stack overflow indicating that a recursive function in a model may need a bigger stack size.

See the MainThread.java and search for "internal error" e.g:

setException(new Exception("internal error", e));

If a stack overflow exception is thrown it just shows "internal error" in the debugger by sending the following messages:

<?xml version="1.0" encoding="UTF-8"?><response command="run" transaction_id="120"><error code="206" apperr=""><message>internal error</message></error></response>

<?xml version="1.0" encoding="UTF-8"?><response command="stack_get" transaction_id="121"><error code="5" apperr=""><message>stack_get -i 121</message></error></response>

but it could have done better since the exception it caught was a stackoverflow inner exception.

@lausdahl lausdahl added the enhancement Not a bug, but nice to have label May 7, 2015
@lausdahl lausdahl added this to the v2.2.6 milestone May 7, 2015
@lausdahl
Copy link
Member Author

lausdahl commented May 7, 2015

Have created this issue for the inconvenient reporting of errors in the AGCO model on certain Java installations with a too small Xss @pglvdm

@afterkelsen afterkelsen modified the milestones: v2.2.6, v2.2.8 Jun 19, 2015
@afterkelsen afterkelsen modified the milestones: v2.2.8, v2.2.10 Oct 7, 2015
@afterkelsen afterkelsen modified the milestones: v2.3.2, v2.3.4 Mar 2, 2016
@afterkelsen afterkelsen modified the milestones: v2.3.6, v2.3.8 May 22, 2016
@peterwvj peterwvj modified the milestones: v2.3.8, v2.3.10 Jul 1, 2016
@peterwvj peterwvj modified the milestones: v2.4.0, v2.4.2 Aug 29, 2016
@peterwvj peterwvj modified the milestones: v2.4.2, 2.4.4 Oct 4, 2016
@peterwvj peterwvj modified the milestones: v2.4.8, v2.5.0 Jun 5, 2017
@peterwvj peterwvj modified the milestones: v2.5.0, v2.5.2 Aug 10, 2017
@peterwvj peterwvj modified the milestones: v2.5.2, v2.5.4 Sep 11, 2017
@peterwvj peterwvj modified the milestones: v2.5.4, v2.5.6 Nov 9, 2017
@peterwvj peterwvj modified the milestones: v2.5.6, v2.5.8 Dec 11, 2017
@peterwvj peterwvj modified the milestones: v2.6.0, v2.6.2 Feb 16, 2018
@peterwvj peterwvj modified the milestones: v2.6.2, v2.6.4 May 17, 2018
@peterwvj peterwvj modified the milestones: v2.6.4, v2.6.6 Oct 18, 2018
@peterwvj peterwvj modified the milestones: v2.7.0, v2.7.2 Jun 3, 2019
@peterwvj peterwvj modified the milestones: v2.7.2, v2.7.4 Sep 30, 2019
@nickbattle
Copy link
Contributor

This enhancement has been fixed in #709.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Not a bug, but nice to have
Projects
None yet
Development

No branches or pull requests

4 participants