Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request | Allow configuration of visibility timeout #189

Open
steffiprofileprint opened this issue May 24, 2023 · 1 comment
Open
Labels
enhancement New feature or request

Comments

@steffiprofileprint
Copy link

Hi guys,

Our team has been using Celery Director for our workflows. Some of our tasks take longer than 1 hour to run, and we are running into this Celery + Redis issue, where long tasks are added to the queue repeatedly. The quick fix for this is to increase visibility_timeout in the broker transport options. I would like to propose to add a new optional environment variable DIRECTOR_VISIBILITY_TIMEOUT for the hidden config. The changes would something like the following in /director/settings.py:

...
# Celery configuration
  self.CELERY_CONF = {
      "task_always_eager": False,
      "broker_url": env.str("DIRECTOR_BROKER_URI", "redis://localhost:6379/0"),
      "result_backend": env.str(
          "DIRECTOR_RESULT_BACKEND_URI", "redis://localhost:6379/1"
      ),
      ### MODIFIED
      "broker_transport_options": {
          "master_name": "director",
          "visibility_timeout": env.int("DIRECTOR_VISIBILITY_TIMEOUT", 3600)
      },
     ###
  }
...

Thanks for reading and for the project, it has been very helpful to us! 👍

@ncrocfer
Copy link
Member

ncrocfer commented Jun 4, 2023

Hello @steffiprofileprint ,

Indeed it can be a new setting to improve the user experience of Celery Director 👍

@ncrocfer ncrocfer added the enhancement New feature or request label Jun 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants