Test improvement proposal

[eversC]

• mock call to ovotech/cloud-key-client

• local key writer

• Unit tests public Rotate() func

• Add e2e tests for all key writers with real resources

[siwally]

Current thoughts are that it's not worth introducing Testify or a similar mocking framework, given we only have a handful of functions to swap in.

Might just mock the function in cases where we don't have an interface, in which case the function can be called anything as long as the signature is the same. See https://stackoverflow.com/questions/19167970/mock-functions-in-go (option 1). Would just roll our own function then to return the test data, rather than use a framework.

[siwally]

Attempting to use cloud-key-client instead of mocking it, but to plug in a new local (i.e. mock) provider type in addition to AWS and GCP. Working in a separate branch (pluggable-providers) on cloud-key-client also.

[eversC]

Closing this one off as unit tests have been added.

e2e tests are a good idea, will raise another issue for that.

[eversC]

In fact, one already exists.... #34