Multiple fetch request #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should complement well #106. |
vlovgr
reviewed
Mar 28, 2019
There was a problem hiding this comment.
Thanks for this @backuitist!
If you rebase on master, the build failure should be fixed.
backuitist
force-pushed
the
multiple_fetch_request
branch
from
88229f5 to
dfe491c
Compare
Codecov Report
@@ Coverage Diff @@
## master #107 +/- ##
==========================================
- Coverage 94.6% 94.21% -0.39%
==========================================
Files 40 40
Lines 1094 1107 +13
Branches 69 73 +4
==========================================
+ Hits 1035 1043 +8
- Misses 59 64 +5
Continue to review full report at Codecov.
|
backuitist
force-pushed
the
multiple_fetch_request
branch
from
dfe491c to
e38d3ed
Compare
vlovgr
reviewed
Apr 1, 2019
This happens when `stream` is called after the underlying Java client gets assigned partitions.
vlovgr
force-pushed
the
multiple_fetch_request
branch
from
e38d3ed to
1d73f2c
Compare
|
Thanks for fixing my commits! Looks all good to me :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.