Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add initial logging #113

Merged
merged 1 commit into from
Apr 1, 2019
Merged

Add initial logging #113

merged 1 commit into from
Apr 1, 2019

Conversation

vlovgr
Copy link
Contributor

@vlovgr vlovgr commented Apr 1, 2019

Fixes #108.

@vlovgr vlovgr merged commit 1013737 into master Apr 1, 2019
@vlovgr vlovgr deleted the logging branch April 1, 2019 11:37
@codecov
Copy link

codecov bot commented Apr 1, 2019

Codecov Report

Merging #113 into master will decrease coverage by 3.42%.
The diff coverage is 58.58%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #113      +/-   ##
==========================================
- Coverage   98.02%   94.59%   -3.43%     
==========================================
  Files          38       40       +2     
  Lines        1011     1091      +80     
  Branches       61       69       +8     
==========================================
+ Hits          991     1032      +41     
- Misses         20       59      +39
Impacted Files Coverage Δ
src/main/scala/fs2/kafka/KafkaConsumer.scala 100% <100%> (ø) ⬆️
src/main/scala/fs2/kafka/internal/syntax.scala 100% <100%> (ø) ⬆️
src/main/scala/fs2/kafka/internal/LogEntry.scala 32.14% <32.14%> (ø)
src/main/scala/fs2/kafka/internal/Logging.scala 46.15% <46.15%> (ø)
.../scala/fs2/kafka/internal/KafkaConsumerActor.scala 90% <67.39%> (-4.69%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 94e3f8c...2c31bf6. Read the comment docs.

@vlovgr vlovgr mentioned this pull request Apr 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant