WIP: Bump version of kafka-clients to 2.1.1 #90
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ues.apache.org/jira/browse/KAFKA-7890 (shop-stopper bug when using kafka-clients in environments where brokers can change their IPs, e.g. Kubernetes)
|
Thanks for this @sebastianvoss! In my experience, the embeddedkafka version has to match exactly with the Kafka client version for it to work. Looks like the update has already been merged (#35), but there's no release yet. As a temporary workaround, 2.1.1 should be binary-compatible with 2.1.0, so if you add it as an explicit dependency in your project, everything should hopefully still work. |
|
@sebastianvoss Looks like it works if we override the Kafka version in tests. I've branched and included this fix in #91. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bump version of kafka-clients to 2.1.1 to get the fix for https://issues.apache.org/jira/browse/KAFKA-7890 (shop-stopper bug when using kafka-clients in environments where brokers can change their IPs, e.g. Kubernetes).
For some reasons test in
KafkaAdminClientSpecare red. Maybe we need to wait forembeddedkafkato release a build for Kafka 2.1.1?!