-
Notifications
You must be signed in to change notification settings - Fork 77
[Tests] Add Definition Tests #168
Comments
taking ClassDefinition tests |
hey @ddmler I've found some misprint in your test-related code - 'defiNTion' instead of 'defiNITion', so I'm fixing that as well |
@ddmler please consider updating phpunit to 5.*, as current "^4.8.26" version is way too out of date |
@yyaremenko 4.8 was a long term support version i think. the support ends february 2017. |
@yyaremenko @ddmler |
@ddmler @ovr PHPSA\Definition\ClassDefinition please advice - should I update the code and disallow null in constructor or should I do it some other way (I am not fully familiar with your code) |
guys, please reply ASAP, I am blocked (can not proceed with writing tests) |
remove null for statement, we always give one. 👍 |
@ddmler okay thanx |
We need tests for the definition directory. Currently we only have some for ClassDefinition and RuntimeClassDefinition but those are not complete too.
You don't have to do all, write here which of them you want to add.
The text was updated successfully, but these errors were encountered: