-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PCRE2 support still requires PCRE1 #2750
Comments
Hello @dvershinin , Yes, that's right, it does still presuppose that you have the legacy pcre installed on your build system as well, even though you want libModSecurity to actually use pcre2. Aside from the nuisance of needing to also install pcre1 even though you don't want it, is this causing you any other problems or difficulties? |
@martinhsv Aside from having to have pcre1 devel on the build system and unnecessarily loading the pcre1 library at runtime (because it ends up linked to the binary) - none that I see. FYI, the nginx module itself, compiled with pcre2 has a similar issue.
|
legacy pcre is in process of being deprecated @ Fedora https://fedoraproject.org/wiki/PcreDeprecation libmodsecurity is listed there as one of the dependent/affected pkgs |
Thanks @dvershinin and @pgnd for highlighting this. |
Debian 12 was released without libpcre++-dev so you can't install PCRE1 anymore but modsec still requires it for building. |
Hello @kub3let , It's not clear from your posting what your situation is, but this issue was closed because it was resolved. If you are using ModSecurity >= v3.0.9, then PCRE1 is not required for the build, but you must still specify |
@kub3let did you successfully build and use it for Debian 12 ? |
Debian 12 (a.k.a. Bookworm) contains libmodsecurity3, and that uses PCRE2 (since 3.0.8): What's the issue with that? |
I wasn't able to build it with PCRE2 but I don't remember why, I fixed it by manually installing PCRE1 from Debian 11, e.g. Since it has no other dependencies it works with Debian 12 as well.
But I would strongly recommend against doing that and instead try with PCRE2 again. |
It would be very nice to figure out the reason. Could you reproduce that? Also: here are the (almost) newest (and non-official) package, including source: https://modsecurity.digitalwave.hu Could you check that too? |
libmodsecurity 3.0.7 compiles fine using
--with-pcre2
only when both pcre1 and pcre2 dev packages are installed, which is wrong...Moreover, the resulting binary links against both libraries... which is further wrong.
If only pcre2 dev package is installed, it fails at
./configure --with-pcre2
saying:In other words,
--with-pcre2
still requires pcre1 dev.The text was updated successfully, but these errors were encountered: