Remove unnecessary dynamic casts #3218
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eduar-hte
force-pushed
the
remove-dynamic-casts
branch
2 times, most recently
from
7056476 to
bc82c5a
Compare
eduar-hte
force-pushed
the
remove-dynamic-casts
branch
8 times, most recently
from
a6fe127 to
ba11edd
Compare
eduar-hte
force-pushed
the
remove-dynamic-casts
branch
2 times, most recently
from
705ea06 to
394c946
Compare
- Refactored duplicate code in RuleWithOperator::getVariablesExceptions - Leveraged auto to simplify declaration of dynamic_cast pointers.
eduar-hte
force-pushed
the
remove-dynamic-casts
branch
from
394c946 to
c917d6a
Compare
|
|
Thanks - I tried to measure the performance with this patch, but didn't get any significant difference (but it might improve it in real environments). Never mind, the patch makes the code more visible indeed, going to merge. |
That's right, these changes are not going to make a noticeable difference, but the goal is to shave off as much as possible over time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
This short PR removes a number of
dynamic_castcasts in the codebase, some of which are performed twice and could be rewritten to perform the runtime cast only once.why
dynamic_castis performed at runtime and requires inspecting the object's RTTI information to perform the cast. Executing it more than once incurs a bit of a performance cost that could be avoided by rewriting the code snippet. Additionally, the rewritten code is shorter and thus easier to read and maintain.For example (from
src/rule_with_actions.cc):can be rewritten as:
misc
This is part of a series of PRs to improve performance of the library (2/n). Previous: #3164