Error in AuditableObserver (v5.0)

[Albvadi]

Q	A
Bug?	yes
New Feature?	no
Framework	Laravel
Framework version	5.5.22
Package version	5.0.0
PHP version	7.0.9

Actual Behaviour

Error trying to save a new instance of a audit model.

Steps to Reproduce

App\Company.php (Model)

use OwenIt\Auditing\Contracts\Auditable;
class Company extends Model implements Auditable
{
    use SoftDeletes;
    use \OwenIt\Auditing\Auditable;

    ...
}

Route

Route::get('/create_company', function () {
    dd((factory(App\Company::class)->create())->toArray());
});

Error:

[quetzyg]

You sure you're on PHP 7.0.9? The only time I had issues like that was with PHP 5.5.x/5.6.x, where I had to use an alias. PHP 7.0.9 shoud be OK with using the same class name, as long as at least one is using the FQCN.

Anyways, try:

use OwenIt\Auditing\Contracts\Auditable as AuditableContract;

class Company extends Model implements AuditableContract
{
    use SoftDeletes;
    use \OwenIt\Auditing\Auditable;

    ...
}

[quetzyg]

The issue was fixed in PHP 7.0.7, btw.

[Albvadi]

Sure, my PHP version it´s 7.0.9. Load in a phpinfo() page inside laravel.

I followed your suggestion, but the problem persist.
Besides, I created and empty laravel installation, only just in case I had forgotten something in the upgrade from 4.1.4 and same problem.

In the new installation, with all default config:
App\User.php

<?php

namespace App;

use Illuminate\Notifications\Notifiable;
use Illuminate\Foundation\Auth\User as Authenticatable;
use OwenIt\Auditing\Contracts\UserResolver;

class User extends Authenticatable implements UserResolver
{
    use Notifiable;

    /**
     * The attributes that are mass assignable.
     *
     * @var array
     */
    protected $fillable = [
        'name', 'email', 'password',
    ];

    /**
     * The attributes that should be hidden for arrays.
     *
     * @var array
     */
    protected $hidden = [
        'password', 'remember_token',
    ];

    /**
     * {@inheritdoc}
     */
    public static function resolveId()
    {
        return Auth::check() ? Auth::user()->getAuthIdentifier() : null;
    }
}

App\Company.php

<?php

namespace App;

use Illuminate\Database\Eloquent\Model;
use OwenIt\Auditing\Contracts\Auditable as AuditableContract;

class Company extends Model implements AuditableContract
{
    use \OwenIt\Auditing\Auditable;
}

routes\web.php

Route::get('/company', function () {
    $company = new Company;
    $company->name = "TEST COMPANY";
    $company->save();
});

Same error in a source file from the package (\vendor\owen-it\laravel-auditing\src\AuditableObserver.php), not in my source code:

[quetzyg]

I followed your suggestion, but the problem persist.

No you didn't, you're not using an alias, like I have in the example above.

[Albvadi]

Was a copy/paste problem... sorry.
But, tried with your suggestion... problem persist.

[Albvadi]

Besides, downgrade from 5.0.1 to 4.1.4, works perfect without touching my model setup

[quetzyg]

Any 4.1.x version has the alias set to prevent such issue, but like I said, this is a PHP 5.5.x/5.6.x and 7.0.0 to 7.0.7 problem.

These are the PHP 5.5.21 and 5.6.5 builds failing on Travis CI, exactly because of that. Once I added aliases, the tests passed.

Tests don't lie.
#shakira

The issue you're having should not happen in the PHP version you say you have. So you either have multiple PHP versions and you think you're using one, instead of another, or the issue wasn't properly fixed in PHP 7.0.7 and you need a higher version.

Try upgrading to a more recent PHP version and see if the issue disappears.

Version 7.0.x won't be actively supported for much longer, anyway.

[Albvadi]

Upgraded PHP to 7.0.13 solve the issue without using alias.

I'm sorry I bothered you so much.
Maybe you should update the readme.md to avoid people like me.

Thanks for all your support!

[quetzyg]

Not a problem, I'll update the composer.json requirements and bump the PHP version to avoid similar issues.

[quetzyg]

I just checked the changelog for 7.0.13 and it does fix the issue.

[Albvadi]

I thought I was going crazy!!
Thanks for your research!