Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

etl run --export should default to a matching branch for other repos #3537

Open
larsyencken opened this issue Nov 14, 2024 · 2 comments
Open

Comments

@larsyencken
Copy link
Collaborator

larsyencken commented Nov 14, 2024

Problem

In our ETL staging work, we are moving to using matching branches (my-data-change) on both the ETL and owid-content.

Currently our etl run --export does a dry-run push to master on owid-content and other repositories, such as co2-data. You use an environment variable to pick which branch to do a real push to. But actually we should default to the matching branch name in the external repo.

This will make them work more harmoniously with the new staging flow.

@larsyencken larsyencken changed the title Explorer export function should default to a matching branch on push etl run --export should default to a matching branch for other repos Nov 14, 2024
@larsyencken
Copy link
Collaborator Author

Recall:

  • We have external namespace, to remind us that someone else is using this
  • We have export, which is meant to be for things we push elsewhere
  • We want to turn the OWID external steps into export steps, meaning that at the ETL you have control over publishing that data

@Marigold
Copy link
Collaborator

This has been implemented for etlr github/co2_data --export step in this PR #3605. Other steps could use the same pattern.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants