Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data catalog: topic filter not applied when search query revised but not executed #4318

Open
bnjmacdonald opened this issue Dec 16, 2024 · 1 comment

Comments

@bnjmacdonald
Copy link
Contributor

bnjmacdonald commented Dec 16, 2024

Description

When a visitor to the data catalog types in or edits a search query and does NOT hit "enter" to execute the query, then any subsequent click on a topic filter executes the revised search query instead of applying the topic filter.

Expected behaviour

As a user, I'd expect the topic filter to be applied b/c it is what I clicked on. Unclear whether it is better to also use the revised search query alongside the topic filter or to keep the pre-existing search query.

Steps to reproduce

Screen.Recording.2024-12-16.at.2.36.24.PM.mov

Environment

Happening in at least Chrome + Safari on Mac.

Other notes

I have not specifically seen this bug in session replays. But I often see users edit but not submit a search query, so reasonable to imagine this has affected some small minority of user sessions.

@rakyi
Copy link
Contributor

rakyi commented Jan 7, 2025

The simplest fix seems to be to apply the topic filter, but don't clear (or apply) the search terms.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants