Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cycle 2025.1: data insights with a single image #4416

Open
5 tasks
ikesau opened this issue Jan 8, 2025 · 0 comments
Open
5 tasks

Cycle 2025.1: data insights with a single image #4416

ikesau opened this issue Jan 8, 2025 · 0 comments

Comments

@ikesau
Copy link
Member

ikesau commented Jan 8, 2025

Making it possible to publish data insights with only one file, and updating the designs to assume this as the default going forward

Motivation

Having to create 2 static visualizations per DI significantly increases the overhead in giving feedback and making revisions. We want to halve this by making it so that DIs only use one square image going forward.

Proposed scope

Figma

Must do

  • Update DI feed page to make the sections narrower
  • Update DI typography and spacing
  • Update the homepage to use the square image
  • Update the way images are rendered in data insights
    • Ensure og:image is still set correctly, and the Atom feed image.

Technical notes

I think something like a preferSmall option for the Image component will be a nice way to migrate all previous DIs that have 2 images specified, while also allowing authors to only specify filename in archie going forward (filename is mandatory whereas smallFilename is optional - the other potential solution would be to change this so that validation ensures that either one or both are defined and then handle that in the Image component, but that seems more likely to leak into other parts of the site)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant