Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build failure on platforms with no shared libraries #20

Open
nandor opened this issue Dec 10, 2019 · 3 comments
Open

Build failure on platforms with no shared libraries #20

nandor opened this issue Dec 10, 2019 · 3 comments

Comments

@nandor
Copy link
Contributor

nandor commented Dec 10, 2019

The library expects ocamlmklib to produce both a shared and a static library:

https://github.com/owlbarn/eigen/blob/master/eigen_cpp/dune#L3

If OCaml is compiled without shared libraries, this rule fails. Could the problematic rule be rewritten into a dune stanza that omits building a shared library for a static environment?

Dune now seems to support targets with no shared libs:

ocsigen/lwt#599

@mseri
Copy link
Member

mseri commented Dec 10, 2019

Yes, this seems doable indeed. I don’t have time to work on it at the moment, but I would be happy to review a PR fixing it

@nandor
Copy link
Contributor Author

nandor commented Dec 11, 2019

I'd be happy to work on a patch to provide support for cross compilation and static libraries. Would it be a problem if I also upgraded to dune 2.0?

@mseri
Copy link
Member

mseri commented Dec 11, 2019

That will not be a problem as long as owl is still building fine with dune2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants