Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Faulty interaction between IAO:0000231 and replaced_by #140

Open
matentzn opened this issue Aug 2, 2023 · 3 comments
Open

Faulty interaction between IAO:0000231 and replaced_by #140

matentzn opened this issue Aug 2, 2023 · 3 comments
Labels
1.4 major issues issues that are priority to address in 1.6 Priority-Critical

Comments

@matentzn
Copy link

matentzn commented Aug 2, 2023

Minimal ontology:

format-version: 1.2
ontology: mondo

[Term]
id: MONDO:0000865
name: obsolete congenital fiber-type disproportion
property_value: IAO:0000231 IAO:0000227
is_obsolete: true
replaced_by: MONDO:0009711

[Term]
id: MONDO:0009711
name: congenital fiber-type disproportion myopathy

Save with OWLAPI 3.5.25:

format-version: 1.2
ontology: mondo
owl-axioms: Prefix(owl:=<http://www.w3.org/2002/07/owl#>)\nPrefix(rdf:=<http://www.w3.org/1999/02/22-rdf-syntax-ns#>)\nPrefix(xml:=<http://www.w3.org/XML/1998/namespace>)\nPrefix(xsd:=<http://www.w3.org/2001/XMLSchema#>)\nPrefix(rdfs:=<http://www.w3.org/2000/01/rdf-schema#>)\n\n\nOntology(\nDeclaration(AnnotationProperty(<http://www.geneontology.org/formats/oboInOwl#id>))\n\n\nAnnotationAssertion(<http://www.geneontology.org/formats/oboInOwl#id> <http://purl.obolibrary.org/obo/MONDO_0000865> \"MONDO:0000865\")\nAnnotationAssertion(rdfs:label <http://purl.obolibrary.org/obo/MONDO_0000865> \"obsolete congenital fiber-type disproportion\")\n)

[Term]
id: MONDO:0009711
name: congenital fiber-type disproportion myopathy
alt_id: MONDO:0000865

Funnily this works:

format-version: 1.2
ontology: mondo

[Term]
id: MONDO:0000865
name: obsolete congenital fiber-type disproportion
property_value: IAO:0000231 somestring
is_obsolete: true
replaced_by: MONDO:0009711

[Term]
id: MONDO:0009711
name: congenital fiber-type disproportion myopathy

Note the property_value: IAO:0000231 somestring

This is a big problem for Mondo because I am trying to standardise all OBO ontologies to using obsolescence reasons correctly.

@balhoff
Copy link
Member

balhoff commented Aug 2, 2023

@matentzn terms merged is baked into the OWL API OBO parser to model alt_ids (parsing an OBO file containing alt_ids converts the alt_ids to obsolete terms with a replaced_by value of the main term, as well as an obsoletion reason of terms merged). I think this value should just be avoided completely if using OBO 1.2/1.4. 🫤 Maybe we can exclude alt_id from OBO 1.6.

@balhoff
Copy link
Member

balhoff commented Aug 2, 2023

Oh, and the reason I assume for the owl-axioms header is that the obsolete terms that become alt_ids don't have a frame of their own in OBO, so no place to put their annotations.

@dosumis
Copy link

dosumis commented Aug 2, 2023

@matentzn terms merged is baked into the OWL API OBO parser to model alt_ids (parsing an OBO file containing alt_ids converts the alt_ids to obsolete terms with a replaced_by value of the main term, as well as an obsoletion reason of terms merged). I think this value should just be avoided completely if using OBO 1.2/1.4. 🫤 Maybe we can exclude alt_id from OBO 1.6.

Really important to have a standard & well documented migration strategy for any existing alt_ids - given their long legacy. That was the point of the baked-in conversion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.4 major issues issues that are priority to address in 1.6 Priority-Critical
Projects
None yet
Development

No branches or pull requests

3 participants