Mark news as read

[derflasher]

Hi there!

When I scroll too fast through the news, sometimes the news aren't mark as read while using this function.
Is it a bug or a feature?

[David-Development]

Well.. It's a feature :)

... just kidding .. yea.. I think it's because the scrolling is "too fast". I think that the listview is not triggering the "scroll" event fast enough. The result is, that some rows will be skipped (not marked as read).

Since you are scrolling really fast I guess you are not interested in the feeds and you simply want to mark them as read, right? Maybe you can use the option "mark all as read" instead.

[derflasher]

Yes and no.

Sometimes I read the headlines of the feeds very fast and they ain't marked as read....
Sometimes I just want to mark the first few feeds as read, but not the entire subscription. Because some older feeds should not be marked as read.

[David-Development]

Did the update solve the problem? Or is it still buggy?

[derflasher]

This works better, yes! Good job!
But: If the feed list is less than a screen-height, the feeds ain't marked as read :-(
You have to mark them manually as read....

[David-Development]

Yes, that is true. What would be the expected behavior?

I was thinking about marking them as read automatically. However, if you open a list by accident (which has less unread items than the screen-height), all items in this list will be marked as read. And you have to unmark them manually. That's why I decided to leave the user to mark those items as read manually.

[derflasher]

Yes, the unwanted mark-as-read-process is annoying.

I suggest to add an extra field at the end of the list:
Press here to mark feeds above this line as read!

What do you think about that?

[David-Development]

Thanks for the suggestion. It is not that trivial to add such an additional line. Furthermore there is a "risk" involved here. Assume the following case: Let's say your screen can contain 8,1 Elements. And you have 8 unread items in a feed. Therefore by opening the feed you would see all 8 items and you can't scroll since they all fit on the screen. Adding an additional line would require the user to scroll down in order to see, that the last item is only there to mark the above as read. But as the user scrolls, the list will be marked as read anyways. Just a little paradox.. In terms of simple design I would prefer no additional visual elements. Maybe I can check if the users touches the list (does a scroll movement) that the all items in the list will be marked as read.

[derflasher]

Yes, you're right with your example.

What about this solution:
You split the screen in 2 sides. On the left side, you can swipe from left to right in order to open the menu and not to mark the feeds accidently read. The right side is to mark the feeds as read.
This doesn't require any visual elements...

[morph027]

I was using feedly before (and finally migrated over to my nextcloud with news now) ... I liked their android app, they are swiping whole pages instead of scrolling the items.

So let's say you have 10 feed items per page, then you swipe up get the next 10 and so on and the last page was a single page with just one button "mark all as read" ;)

[derflasher]

In the latest F-Droid-version has the behaviour changed.
The feeds all marked read if sliding the menu from the left to the right.....
In the previous F-Droid-version the feeds haven't been marked read.
Is it just a version-bug or did you intended to chang it?

[David-Development]

@derflasher No, we did not intent to get this kind of behaviour. As you can see in #633 we had some problems when the list is almost empty, the swipe/scroll was not recognized. Therefore we changed the swipe detector. I need to investigate this issue a little more to give some more feedback.

ping @AnotherDaniel

[AnotherDaniel]

@derflasher can you explain in detail what you are doing to get the undesired behavior?
I'm trying to slide everything to anywhere, but I don't think I'm getting whatever happens for you.

[derflasher]

Sure, you've got mail :-)

[AnotherDaniel]

@derflasher thank you for the video - and: crap, it definitely shouldn't do that, and I can't replicate this yet. What are your general settings?

[David-Development]

@AnotherDaniel Just watched the video and I think the reason is, that the swipe is performed "over" the recyclerview. Therefore the recyclerview is picking up that event. Also the swipe in the video is going upwards (downwards shouldn't be a problem). I guess the "mark as read while scrolling" feature is enabled.

I think the following line is the problem:

news-android/News-Android-App/src/main/java/de/luhmer/owncloudnewsreader/NewsReaderDetailFragment.java

Line 501 in 17d52a5

if(mMarkAsReadWhileScrollingEnabled && (e2.getY() - e1.getY()) < 0) { // (distance < 0) => scroll up

There is also a second line that is calling the scroll event (however that line shouldn't be problematic..):

news-android/News-Android-App/src/main/java/de/luhmer/owncloudnewsreader/NewsReaderDetailFragment.java

Line 418 in 17d52a5

if(dy > 0) { //check for scroll down

Another important prerequisite: The number of unread items might not exceed the screen. Since we're already on the bottom of the screen, all remaining items will be marked as read.

news-android/News-Android-App/src/main/java/de/luhmer/owncloudnewsreader/NewsReaderDetailFragment.java

Line 480 in 17d52a5

if (reachedBottom &&

[derflasher]

@derflasher thank you for the video - and: crap, it definitely shouldn't do that, and I can't replicate this yet. What are your general settings?

[AnotherDaniel]

Ok - I'm on a business trip this week, so can only have a more detailed look at this Friday-ish; but I just managed to replicate the undesired behavior so that's something...

[David-Development]

I think this is fixed now thanks to @AnotherDaniel. If you encounter any further issues.. please let me know and reopen!