swipe upwards to mark as read

[jakejoh]

A couple of versions ago (unfortunately, I do not remember which one), it was possible to have articles marked as read by simply swiping up - even without enough unread items to actually being able to scroll through them. Currently, I have to use the menu if there are less than 5 items in the list.

[AnotherDaniel]

This might be related to the change done for #590? Or rather #343? Having a look around...

[AnotherDaniel]

@David-Development Its me again :)
I find that re-adding addOnItemTouchListener lines 409ff in NewsReaderDetailFragment.java addresses this issue - what was the reason you removed that part of the code? It should not interfere with the #343 fix I think...

[David-Development]

@AnotherDaniel Sorry for the late reply. I had to look into the code to figure out why I removed it. Mainly the reason was a poor scroll experience when the feature "mark as read while scrolling" is enabled. The callback onScroll is called many times a second - resulting in tons of expensive calculations which results in scrolling lags and skipped items if the user scrolls a little faster.

I thought about how to implement this and I think adding a small flag that enabled this "swipe up" feature if less then e.g. 10 items in the list would be good (usually 3-5 items fit on the screen). If the list is longer than 10 items, it won't take up any computational power and cause any scrolling lags etc.
I created a PR #666 - let me know what you think :)

Thanks for the research! It's always been a tricky feature with many side-effects..