Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve sharing permissions acceptance tests #278

Closed
SergioBertolinSG opened this issue Jul 8, 2016 · 4 comments
Closed

Improve sharing permissions acceptance tests #278

SergioBertolinSG opened this issue Jul 8, 2016 · 4 comments

Comments

@SergioBertolinSG
Copy link
Contributor

Currently smashbox is doing a full test of permissions.

We need that in integration tests.

ref: owncloud/core#25389

If would require to check in the filesystem if the permissions are respected.

@PVince81
Copy link
Contributor

PVince81 commented Apr 6, 2017

Will there be time for this in the OC 10 timeframe, after all other important stuff is done ?

@phil-davis
Copy link
Contributor

@paurakhsharma we have been extending the sharing acceptance tests with different ownCloud permissions.
Issue owncloud/core#31531 has relevant links to PRs.

We need to review what we have done there. Then see what the smashbox stuff is doing and make tests to cover that also.

@phil-davis phil-davis changed the title Improve sharing permissions integration tests Improve sharing permissions acceptance tests Aug 17, 2018
@skshetry
Copy link
Member

skshetry commented Jul 8, 2019

@phil-davis Can we close this? You have already done a lot of tests regarding sharing permissions already.

@phil-davis
Copy link
Contributor

Yes, create share, re-share and update share have combinations of permissions tested nowadays.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants