Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Phan / PHPSTAN extension to replace occ app:check-code #587

Open
patrickjahns opened this issue Aug 28, 2018 · 2 comments
Open

Create Phan / PHPSTAN extension to replace occ app:check-code #587

patrickjahns opened this issue Aug 28, 2018 · 2 comments

Comments

@patrickjahns
Copy link
Contributor

patrickjahns commented Aug 28, 2018

The code-checker inside ownCloud has been useful in the past. Instead of however needing to maintain (and ship it as supportable code), lets move the functionality to a static code analyzer like phan or phpstan

Code in question:
https://github.com/owncloud/core/tree/master/lib/private/App/CodeChecker

cc @PVince81 @DeepDiver1975

@PVince81
Copy link
Contributor

I seem to remember a discussion where it was said that we could extend Phan with rules that would help check that apps are using only OCP symbols and no OC_ ones ?

@patrickjahns
Copy link
Contributor Author

That is exactly what this ticket is about ;-). Backlog item to remember to do this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants