Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor ExoPlayer #3144

Open
theScrabi opened this issue Mar 10, 2021 · 1 comment
Open

Refactor ExoPlayer #3144

theScrabi opened this issue Mar 10, 2021 · 1 comment
Assignees

Comments

@theScrabi
Copy link
Contributor

The code we use for the video preview is a bit cluttered. So I'd like to propose to refactor it. Here are some suggestions we should apply:

  • The Player view is split up into a PreviewVideoActivity, which is used for full screen playback, and a PreviewVideoFragment which is used for embedded playback. Both share the same code which is redundant and requires communication between both. I suggest to remove the PreviewVideoActivity and try to make the fragment be shown in fullscreen mode if possible.
  • PreviewVideoActivity and PreviewVideoFragment both implement a couple of listeners. This bloats the code size of them both. I'd suggest to "pull" the listener parts out of these classes and make them independent from it.
  • Update to Kotlin. Because while doing that modernizing the code would be a good idea.

I'd also propose to do this before redesigning the player. This way we can make sure our next steps are build on solid ground.

@jesmrec
Copy link
Collaborator

jesmrec commented Apr 9, 2021

Will need research before.

@jesmrec jesmrec modified the milestones: 2.18-current, 2.19-next May 6, 2021
@jesmrec jesmrec modified the milestones: 2.19-current, 2.20-... Aug 12, 2021
@jesmrec jesmrec modified the milestones: 2.20-current, -next Dec 9, 2021
@jesmrec jesmrec modified the milestones: 2.21-current, 2.22-next Apr 25, 2022
@michaelstingl michaelstingl modified the milestones: 4.1 - Next, backlog Apr 13, 2023
@JuancaG05 JuancaG05 removed this from the backlog milestone May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants