Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPACES] Get Personal spaces quota from GraphAPI #3874

Closed
10 tasks done
jesmrec opened this issue Jan 26, 2023 · 3 comments · Fixed by #4401
Closed
10 tasks done

[SPACES] Get Personal spaces quota from GraphAPI #3874

jesmrec opened this issue Jan 26, 2023 · 3 comments · Fixed by #4401

Comments

@jesmrec
Copy link
Collaborator

jesmrec commented Jan 26, 2023

Quota is displayed at the bottom of the side menu. Legacy and current behaviour is showing the personal space quota. So, we should always show the personal space quota in the drawer (the general quota for oC10).

Now, this value should be fetched from GraphAPI's drives endpoint in case of oCIS, and keeping the current behaviour for 0C10.

"quota" : {
            "remaining" : 2655551488,
            "state" : "normal",
            "total" : 0,
            "used" : 66351210
},

Docs: https://owncloud.dev/libre-graph-api/#/me.drives/ListMyDrives

TASKS

  • Research (if needed)
  • Create branch feature/personal_space_quota
  • Development tasks
    • Implement logic for oC10
    • Implement logic for oCIS
    • Implement unit tests (if needed)
  • Code review and apply changes requested
  • Design test plan
  • QA
  • Merge branch feature/personal_space_quota into master
@jesmrec jesmrec added the Spaces label Jan 26, 2023
@jesmrec jesmrec added this to the 4.0 - Current milestone Feb 3, 2023
@abelgardep
Copy link
Contributor

I understand the idea, but oCIS has compatibility with this AFAIT:
Propfind Requesthttps://server/remote.php/dav/files/user

<?xml version='1.0' encoding='UTF-8' ?>
<propfind xmlns="DAV:" xmlns:CAL="urn:ietf:params:xml:ns:caldav" xmlns:CARD="urn:ietf:params:xml:ns:carddav" xmlns:SABRE="http://sabredav.org/ns" xmlns:OC="http://owncloud.org/ns">
    <prop>
        <quota-used-bytes />
        <quota-available-bytes />
    </prop>
</propfind>

Response:

<d:multistatus xmlns:s="http://sabredav.org/ns" xmlns:d="DAV:" xmlns:oc="http://owncloud.org/ns">
    <d:response>
        <d:href>/remote.php/dav/files/user/</d:href>
        <d:propstat>
            <d:prop>
                <d:quota-used-bytes>16996007</d:quota-used-bytes>
                <d:quota-available-bytes>-2</d:quota-available-bytes>
            </d:prop>
            <d:status>HTTP/1.1 200 OK</d:status>
        </d:propstat>
    </d:response>
</d:multistatus>

Is it planned to remove the compatibility?
Do we need to show something different here?

@michaelstingl
Copy link
Contributor

Spaces have quota information in the Graph endpoint. Better align quota handling across Personal Space and Project Spaces?

@jesmrec jesmrec modified the milestones: 4.0 - Current, 4.1 - Next Apr 13, 2023
@michaelstingl michaelstingl added p3-medium Normal priority p4-low Low priority and removed p3-medium Normal priority labels Apr 13, 2023
@jesmrec jesmrec modified the milestones: 4.1 - Next, 4.2 - Future Jun 12, 2023
@jesmrec jesmrec modified the milestones: 4.2 - Current, 4.3 - Future Jan 19, 2024
@JuancaG05
Copy link
Collaborator

@TheOneRing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants