Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Av. offline files removed locally with the Local only option #4353

Closed
jesmrec opened this issue Apr 2, 2024 · 0 comments · Fixed by #4399
Closed

[BUG] Av. offline files removed locally with the Local only option #4353

jesmrec opened this issue Apr 2, 2024 · 0 comments · Fixed by #4399

Comments

@jesmrec
Copy link
Collaborator

jesmrec commented Apr 2, 2024

Steps to reproduce

  1. Set as av. offline any file that is inside other folder (recursive)
  2. Long press over the container folder
  3. Select Remove
  4. Select Local Only

Actual behaviour

The local copy(s) of the av. offline file(s) are removed from internal storage. Recovered when browsing or when the av. offline worker runs

Expected behaviour

Local copies of av. offline files should be never removed. Available offline means "downloaded + synced", so, we can not get rid of local copies because a lack of connection before a sync could lead users to a non-reachable status, breaking the av. offline condition.

After developing a solution for #3936, the option Local Only is only displayed in case of folders, if any file inside is downloaded. An extra condition should be added, so that, this is the new expected result:

Local only displayed:

  • For files: When downloaded but not available offline (already done) ✅
  • For folders: When contain downloaded files that are not av. offline
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants