Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[a11y] 11.1.4.11 Non-text contrast #4365

Closed
3 tasks done
Tracked by #4398
tschiebel opened this issue Apr 5, 2024 · 4 comments · Fixed by #4433
Closed
3 tasks done
Tracked by #4398

[a11y] 11.1.4.11 Non-text contrast #4365

tschiebel opened this issue Apr 5, 2024 · 4 comments · Fixed by #4433

Comments

@tschiebel
Copy link

tschiebel commented Apr 5, 2024

audit: https://infinite.owncloud.com/s/QtwuiGHikwFjozV

https://www.etsi.org/deliver/etsi_en/301500_301599/301549/03.02.01_60/en_301549v030201p.pdf
https://github.com/BIK-BITV/BIK-App-Test/tree/main/Pr%C3%BCfschritte/de

Note: Information-bearing graphics and graphic control elements as well as their states should have a contrast of at least 3:1 to adjacent colors.

Personal Space

  • The edges of the "Search folder" input field and the button for deleting search entries do not meet the contrast requirements for graphical control elements.
    image

Edit shared Link

  • Adjust contrast for switches (if necessary)

Note: If the two switches are not native elements, the contrasts should be adjusted accordingly. Only native switches
are an exception.

Spaces

  • "Search folder" input field and the button for deleting search entries - See comment on Personal Space.
@jesmrec
Copy link
Collaborator

jesmrec commented Apr 9, 2024

@jesmrec
Copy link
Collaborator

jesmrec commented Jun 28, 2024

It will move to an approach like https://m3.material.io/components/search/overview, with a bubble-like. Needs a first research to assure it is feasible.

In terms of branding: by default the primary color and the bubble background color will be the same.

@JuancaG05
Copy link
Collaborator

JuancaG05 commented Jul 2, 2024

We'll address here the changes related to the toolbar mentioned in #4364:

Personal Space

  • The labelling of the "Browse folder" input field does not meet the contrast requirements for texts, as the contrast ratio is only approx. 2.9:1.
    image

Spaces

  • The label of the "Search folder" input field does not meet the contrast requirements for text, as the contrast ratio is only approx. 2.9:1.
    image

@Aitorbp Aitorbp self-assigned this Jul 2, 2024
@Aitorbp Aitorbp linked a pull request Jul 3, 2024 that will close this issue
2 tasks
@JuancaG05
Copy link
Collaborator

  • Adjust contrast for switches (if necessary)

Note: If the two switches are not native elements, the contrasts should be adjusted accordingly. Only native switches
are an exception.

This one won't be addressed because switches are native elements

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants