Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TECHNICAL] Rely on resharing capability #4397

Open
6 of 10 tasks
JuancaG05 opened this issue May 3, 2024 · 5 comments · May be fixed by #4472
Open
6 of 10 tasks

[TECHNICAL] Rely on resharing capability #4397

JuancaG05 opened this issue May 3, 2024 · 5 comments · May be fixed by #4472

Comments

@JuancaG05
Copy link
Collaborator

JuancaG05 commented May 3, 2024

The resharing capability has been set to false by default in oCIS servers (owncloud/ocis#8842), and we realised that we're sending the wrong permissions within the OCShare object. We always give it share permission although the server doesn't allow it. We also show the Can share switch enabled when editing a share. So, several acceptance criteria here:

  • Send correct permissions within the OCShare object, depending on resharing capability
  • If resharing capability is false, disable the Can share switch for shares

TASKS

  • Research (if needed)
  • Create branch technical/rely_on_resharing_capability_ocis
  • Development tasks
    • Set correct permissions in OCShare object
    • Disable Can share switch when resharing is false
    • Implement unit tests (if needed)
  • Code review and apply changes requested
  • Design test plan
  • QA
  • Merge branch feature/rely_on_resharing_capability_ocis into master
@TheOneRing
Copy link
Member

Correction:
The code enabling resharing for the share jail was removed. The capability will always be false.
Our main concern is to disable resharing for the sharejail in any case. Files in the sharejail might provide the R permission but we should never offer the option to share them.

@jesmrec
Copy link
Collaborator

jesmrec commented May 3, 2024

iOS related: owncloud/ios-app#1353

@JuancaG05 JuancaG05 added the New app (only oCIS) Stuff related with a new app in which only oCIS will be supported label May 10, 2024
@jesmrec jesmrec added this to the 4.4 - Future milestone May 31, 2024
@jesmrec
Copy link
Collaborator

jesmrec commented Aug 1, 2024

Follow up: owncloud/ocis#9681

@jesmrec
Copy link
Collaborator

jesmrec commented Aug 1, 2024

Rolling version not following the R: propfinded items with R are not allowed to be reshared.

@jesmrec
Copy link
Collaborator

jesmrec commented Aug 13, 2024

Update: owncloud/ocis#9681 (comment)

R does not mean resharing. We have to mind the capability.

If capability is false (as it is expected in oCIS servers from now on):

  • The share permission should be removed from default in private shares (now, it is 31)
  • The Can Share permission should be gone or disabled in the sharing dialog

@jesmrec jesmrec changed the title [TECHNICAL] Rely on R permission and ignore resharing capability for oCIS accounts [TECHNICAL] Rely on resharing capability for oCIS accounts Aug 16, 2024
@JuancaG05 JuancaG05 self-assigned this Sep 6, 2024
@JuancaG05 JuancaG05 removed the New app (only oCIS) Stuff related with a new app in which only oCIS will be supported label Sep 18, 2024
@JuancaG05 JuancaG05 linked a pull request Sep 20, 2024 that will close this issue
2 tasks
@JuancaG05 JuancaG05 linked a pull request Sep 20, 2024 that will close this issue
2 tasks
@JuancaG05 JuancaG05 changed the title [TECHNICAL] Rely on resharing capability for oCIS accounts [TECHNICAL] Rely on resharing capability Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants