-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[a11y] Correct label for each activities and fragments #4470
[a11y] Correct label for each activities and fragments #4470
Conversation
c78a272
to
1dd58d5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some changes requested here @Aitorbp
owncloudApp/src/main/java/com/owncloud/android/presentation/settings/SettingsActivity.kt
Show resolved
Hide resolved
...loudApp/src/main/java/com/owncloud/android/presentation/files/details/FileDetailsFragment.kt
Outdated
Show resolved
Hide resolved
83c63ad
to
acf97ae
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, moving to QA
As far a i can see, these are the affected views: Folder picker ✅ |
The problem with the audio preview only happens in Android 14. Checked with a device in an older Android version and works |
…Activity in the Manifest
0329aaa
to
23397dd
Compare
Related Issues
App: #4458
ReleaseNotesViewModel.kt
creating a newReleaseNote()
with String resources (if required)QA