Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[a11y] Wrong name in toolbar Share View #4471

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[a11y] Wrong name in toolbar Share View #4471

wants to merge 1 commit into from
+1 −1

Conversation

Aitorbp
Copy link
Collaborator

@Aitorbp Aitorbp commented Sep 20, 2024

Related Issues

App:

  • Add changelog files for the fixed issues in folder changelog/unreleased. More info here
  • Add feature to Release Notes in ReleaseNotesViewModel.kt creating a new ReleaseNote() with String resources (if required)

QA

@Aitorbp Aitorbp self-assigned this Sep 20, 2024
@Aitorbp Aitorbp linked an issue Sep 20, 2024 that may be closed by this pull request
[a11y] Wrong name in toolbar Share View #4469
Open
@Aitorbp
Copy link
Collaborator Author

Aitorbp commented Sep 20, 2024

I have added this requireActivity().setTitle(R.string.share_dialog_title) back to the ShareFileFragment class, because when we go back from Users and groups it does not take the label reference.

@JuancaG05 JuancaG05 changed the title [BUG] Wrong name in toolbar Share View [a11y] Wrong name in toolbar Share View Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JuancaG05 JuancaG05 Awaiting requested review from JuancaG05

At least 1 approving review is required to merge this pull request.

Assignees

@Aitorbp Aitorbp

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[a11y] Wrong name in toolbar Share View
1 participant
@Aitorbp