Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review usages of FolderStatusModel::data #10063

Closed
fmoc opened this issue Aug 25, 2022 · 1 comment
Closed

Review usages of FolderStatusModel::data #10063

fmoc opened this issue Aug 25, 2022 · 1 comment
Milestone
Desktop 6.0

Comments

@fmoc
Copy link
Contributor

fmoc commented Aug 25, 2022

As seen in #10058, FolderStatusModel::data may return invalid QVariants. In this case, we forgot to handle a case (subfolders) properly, and checking for validity might have saved us from some trouble there.

Since data is used in a variety of places, we might want to Q_ASSERT(xyz.valid()) in those places as well.
@fmoc fmoc added this to the 3.0 milestone Aug 25, 2022
@fmoc
Copy link
Contributor Author

fmoc commented Aug 26, 2022

See also #10065.

@TheOneRing TheOneRing modified the milestones: 3.0, 4.0 Sep 8, 2022
@TheOneRing TheOneRing modified the milestones: 4.0, 5.0 Dec 8, 2022
@TheOneRing TheOneRing modified the milestones: Inbox, Desktop 5.0, Desktop 6.0 Aug 31, 2023
@fmoc fmoc assigned erikjv and unassigned erikjv Nov 17, 2023
@fmoc fmoc closed this as not planned Won't fix, can't repro, duplicate, stale Nov 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Desktop 6.0
Development

No branches or pull requests
4 participants
@erikjv @TheOneRing @michaelstingl @fmoc