[QA] Connection closed when syncing a file exceeding quota

[HanaGemela]

Pre-submission Checks

• I checked for similar issues, but could not find any. I also checked the closed issues. I could not contribute additional information to any existing issue.
• I will take the time to fill in all the required fields. I know that the bug report may be dismissed otherwise due to lack of information.

Describe the QA issue

Connection closed when syncing a file exceeding quota

client mac 3.0.0 rc3
server ocis 2.0.0 rc2

Steps to reproduce the issue

1. Sync a file that exceeds the quota

Screenshots

Expected behavior

Error message about exceeding quota

Actual behavior

22-11-30 12:26:04:057 [ debug sync.propagator.upload.tus ]	[ OCC::PropagateUploadFileTUS::makeCreationWithUploadJob ]:	FullPath: "/mytestfile3g" Base64: "L215dGVzdGZpbGUzZw=="
22-11-30 12:26:04:057 [ debug sync.propagator.upload.tus ]	[ OCC::PropagateUploadFileTUS::startNextChunk ]:	Offset: 0 0 Chunk: 100000000 0
22-11-30 12:26:04:058 [ info sync.httplogger ]:	"793e9db2-4ea1-43e0-930c-ce528144716f: Request: POST https://ocis.owncloud.test/dav/spaces/4808fe4d-d318-4038-b5ba-42db0de52cbd$ea0c6569-7c38-4333-974a-174572c96f25 Header: { X-OC-Mtime: 1669751075, Content-Type: application/offset+octet-stream, Content-Length: 100000000, Upload-Offset: 0, Tus-Resumable: 1.0.0, Upload-Metadata: filename L215dGVzdGZpbGUzZw==,checksum U0hBMSAxNjFmY2JmNGJhMzFiYjA1MDM2Y2UzZGEwOGU2YTQ5ZWY2MGFkZGUz, Upload-Length: 3221225472, Authorization: Bearer [redacted], User-Agent: Mozilla/5.0 (Macintosh) mirall/3.0.0.9202-rc3 (ownCloud, osx-22.1.0 ClientArchitecture: x86_64 OsArchitecture: x86_64), Accept: */*, X-Request-ID: 793e9db2-4ea1-43e0-930c-ce528144716f, Original-Request-ID: 793e9db2-4ea1-43e0-930c-ce528144716f, } Data: [100000000 bytes of application/offset+octet-stream data]"
22-11-30 12:26:04:058 [ info sync.networkjob ]:	Created OCC::SimpleNetworkJob(OCC::Account("lucy@ocis.owncloud.test"), "https://ocis.owncloud.test/dav/spaces/4808fe4d-d318-4038-b5ba-42db0de52cbd$ea0c6569-7c38-4333-974a-174572c96f25", "POST", Original-Request-ID: "793e9db2-4ea1-43e0-930c-ce528144716f", X-Request-ID: "793e9db2-4ea1-43e0-930c-ce528144716f") for OCC::PropagateUploadFileTUS(0x600003b96880)
22-11-30 12:26:04:083 [ info sync.httplogger ]:	"793e9db2-4ea1-43e0-930c-ce528144716f: Response: POST 0 (Error: Connection closed,25ms) https://ocis.owncloud.test/dav/spaces/4808fe4d-d318-4038-b5ba-42db0de52cbd$ea0c6569-7c38-4333-974a-174572c96f25 Header: { } Data: []"
22-11-30 12:26:04:084 [ debug sync.propagator.upload.tus ]	[ OCC::PropagateUploadFileTUS::slotChunkFinished ]:	"/mytestfile3g" "POST"
22-11-30 12:26:04:084 [ debug sync.propagator.upload ]	[ OCC::PropagateUploadFileCommon::commonErrorHandling ]:	""
22-11-30 12:26:04:084 [ warning sync.propagator.upload ]:	void OCC::PropagateUploadFileCommon::abortWithError(SyncFileItem::Status, const QString &) "mytestfile3g" "Connection closed"
22-11-30 12:26:04:084 [ info sync.database ]:	Setting blacklist entry for "mytestfile3g" 1 "Connection closed" 1669807564 25 1669751075 "" "" OCC::SyncJournalErrorBlacklistRecord::Category::Normal
22-11-30 12:26:04:084 [ debug sync.database.sql ]	[ OCC::SqlQuery::prepare ]:	SQL prepare "INSERT OR REPLACE INTO blacklist (path, lastTryEtag, lastTryModtime, retrycount, errorstring, lastTryTime, ignoreDuration, renameTarget, errorCategory, requestId) VALUES ( ?1, ?2, ?3, ?4, ?5, ?6, ?7, ?8, ?9, ?10)" Try: 0
22-11-30 12:26:04:084 [ debug sync.database.sql ]	[ OCC::SqlQuery::exec ]:	SQL exec: Estimated query: "INSERT OR REPLACE INTO blacklist (path, lastTryEtag, lastTryModtime, retrycount, errorstring, lastTryTime, ignoreDuration, renameTarget, errorCategory, requestId) VALUES ( 'mytestfile3g', '', '1669751075', '1', 'Connection closed', '1669807564', '25', '', 'OCC::SyncJournalErrorBlacklistRecord::Category::Normal [0]', '793e9db2-4ea1-43e0-930c-ce528144716f')" Actual query: "INSERT OR REPLACE INTO blacklist (path, lastTryEtag, lastTryModtime, retrycount, errorstring, lastTryTime, ignoreDuration, renameTarget, errorCategory, requestId) VALUES ( 'mytestfile3g', '', 1669751075, 1, 'Connection closed', 1669807564, 25, NULL, 0, '793e9db2-4ea1-43e0-930c-ce528144716f')" Try: 0
22-11-30 12:26:04:084 [ debug sync.database.sql ]	[ OCC::SqlQuery::exec ]:	Last exec affected 1 rows.
22-11-30 12:26:04:084 [ info sync.propagator ]:	blacklisting  "mytestfile3g"  for  25 , retry count  1

[michaelstingl]

@TheOneRing re-appearance of owncloud/ocis#4406 ?

/cc @micbar @C0rby

[micbar]

Could be.

@TheOneRing is it a requirement that the server still reads the full request after sending the quota ecxceeded response to the client?

[TheOneRing]

Well I'd assume the http specs to always apply.

[michaelstingl]

@micbar @TheOneRing @HanaGemela This still an issue?

[saw-jan]

Similar issue: owncloud/ocis#5449

[micbar]

was fixed on reva edge.

[TheOneRing]

Thx for the fix