[linux] Virtual files inside a folder are not downloaded after disabling VFS support

[saw-jan]

Describe the bug

After disabling VFS support files inside the folder are not downloaded and .owncloud files of downloaded files are also not removed.

Expected behavior

All files are downloaded and synced to the sync folder

Steps to reproduce the issue

1. Add some files/folders-with-files to the server
2. Add the account to the desktop client with VFS enabled
3. Disable the VFS support
4. Files on root level gets downloaded but respective .owncloued files are still there ❌
5. Files inside some folders don't get downloaded ❌

Screenshots

VFS ON	VFS OFF - root level files are downloaded but .owncloud files still remain ❌

Files inside a folder are not downloaded ❌

Client version number

owncloudcmd ownCloud 5.0.0.12187-rc.2
https://github.com/owncloud/client/commit/5a9119bdfd0794421f9ac7888f05b3ab16df4e59
Libraries Qt 6.4.3, OpenSSL 3.1.2 1 Aug 2023
Using virtual files plugin: suffix
OS: ubuntu-6.2.0-33-generic

Desktop environment (Linux only)

Ubuntu (gnome with nautilus)

Client log

ownCloud.log

[TheOneRing]

Are the two files actual placeholders, empty 1 byte files, or where they modified with a text editor as the client did not download the actual file when double clicking them.

[saw-jan]

Are the two files actual placeholders, empty 1 byte files, or where they modified with a text editor as the client did not download the actual file when double clicking them.

those files were synced from server to the client with vfs enabled and after disabling vfs they should be converted to actual file, right?

[TheOneRing]

Only if they are not modified, if placeholder file is modified its detected as some random file with a stupid file name and ignored.
Your logs would tell you.

[saw-jan]

Only if they are not modified, if placeholder file is modified its detected as some random file with a stupid file name and ignored. Your logs would tell you.

I just synced with vfs on and then disabled vfs. so nothing touched in the sync folder.
I will report the logs as well.

[saw-jan]

I have attached the log in the description. Maybe something can be found there

[TheOneRing]

I can see the file "short.txt.owncloud" in the logs with the same behaviour as INSTALL.sh.owncloud.
And in owncloud/docs-client-desktop#519 I can see a screenshot that that file was opened in a text editor.

[saw-jan]

And in owncloud/docs-client-desktop#519 I can see a screenshot that that file was opened in a text editor.

yeah, for owncloud/docs-client-desktop#519, only short.txt.owncloud is opened in the editor. But for this, I cleaned up everything and tried it fresh

[TheOneRing]

Did the files still exist on the server, if you manage to have .owncloud files on your system that don't have an actual file on the server we would see something like this too.

[saw-jan]

The server has all the files. nothing got deleted

[TheOneRing]

23-09-28 14:51:11:369 [ info sync.discovery ]:	Processing "f1/INSTALL.sh.owncloud" | valid: true/true/db | mtime: 1695645471/1695645471/0 | size: 499/1/0 | etag: "73c7dbc7acff9d85175d3bb3dcfd189e"//"" | checksum: "SHA1:c923cdd0b22dace6b0342b45134186fc45ddb3c1"//"" | perm: "WDNVR"//"" | fileid: "c80f2074-a213-43fd-a607-1a2ab1112e3a$27491a5b-e357-452f-bf4b-d03b51b22eae!eb168cc6-ea33-4997-9fab-82c1b27d1b7b"//"" | inode: 1053049/1053049/ | type: CSyncEnums::ItemTypeVirtualFile/CSyncEnums::ItemTypeVirtualFile/CSyncEnums::ItemTypeFile
23-09-28 14:51:11:369 [ info sync.discovery ]:	Processing "f1/example.sh.owncloud" | valid: true/true/db | mtime: 1695645443/1695645443/0 | size: 729/1/0 | etag: "9da29dc55e4c5851709a2886b1de3c94"//"" | checksum: "SHA1:8645746e32eda723bc16d0dcbac4117040101f72"//"" | perm: "WDNVR"//"" | fileid: "c80f2074-a213-43fd-a607-1a2ab1112e3a$27491a5b-e357-452f-bf4b-d03b51b22eae!2bd6da9f-9e12-40ed-a960-9efb06294799"//"" | inode: 1053065/1053065/ | type: CSyncEnums::ItemTypeVirtualFile/CSyncEnums::ItemTypeVirtualFile/CSyncEnums::ItemTypeFile

For bot files it says it has no mtime on the server and no file size, it looks more like you copied a example.sh.owncloud file to the sync root.

[saw-jan]

hmm, that's not what I did though. Let me do it again in some other VMs

[saw-jan]

hmm, that's not what I did though. Let me do it again in some other VMs

Still same with Debian12. But also now noticed that re-enabling VFS deletes all the .owncloud files (but files are fine in the server)

[saw-jan]

Works for Windows - all vfs files are downloaded

[TheOneRing]

This is a linux issue, what happens on linux?

[saw-jan]

Tested with ownCloud 5.1.1.12577-rc.1 a98b47 on Ubuntu 22.04
All files are downloaded after disabling the VFS ✔️
And no .owncloud files are present ✔️

[TheOneRing]

great, if I just had understood the impact of your finding here earlier 🙈