Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong wording for folder-size setting and corresponding error message #5169

Closed
MarcusWolschon opened this issue Sep 12, 2016 · 6 comments
Closed

Comments

@MarcusWolschon
Copy link

String #1
ownCloud client > settings > general > advanced settings > "[√] ask confirmation before downloading folder larger than [500 MB]".

This setting applies to downloads AND UPLOADS. The wording must be changed into "ask confirmation before SYNCHRONIZING folder larger than"

String #2
"There are new folders that were not synchronized because they are too big:,"
With this message the user is shown an "apply" and "cancel" button.
However the message does not state what the user is supposed to apply or cancel.

"There are new folders not synchronized because they are too big.\n
Exclude and thus delete them from the local hard drive? "

@MarcusWolschon
Copy link
Author

As a bug in a string resource, this needs to be fixed in all translations.

@ogoffart
Copy link
Contributor

Regarding #1: the current message is correct. It is only checking against server-side size of new folder before downloading them.

The second point is valid.

@MarcusWolschon
Copy link
Author

@ogoffart are you sure?
As I was advised in #3989 changing this setting suddenly made it upload my >500MB folders .

@ckamm
Copy link
Contributor

ckamm commented Sep 23, 2016

@MarcusWolschon Yes, if the big-folder limit applied to uploads, that would be a bug. Can you reproduce this problem somehow?

@ckamm
Copy link
Contributor

ckamm commented Sep 23, 2016

@ogoffart What about this wording?

tr("There are new folders that were not synchronized because they are too big. "
   "If you want them synchronized, mark them and click \"Apply\": ") + msg;

@ogoffart
Copy link
Contributor

Fixed by #5204

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants