Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

It is not possible to denote rc1 or beta versions in the beta channel #6651

Closed
jnweiger opened this issue Jul 13, 2018 · 5 comments
Closed

Comments

@jnweiger
Copy link
Contributor

enhancement suggestion:

It is not possible to denote rc1 or beta versions in the beta channel. We can only use the numeric version number
without any suffix. Entries like
'2.4.2rc1'
'2.4.2rc2'
'2.4.2-rc2'
'3.4.2
beta1'
are ignred by the 2.4.2~rc1 client.

@guruz
Copy link
Contributor

guruz commented Jul 16, 2018

@jnweiger I don't understand your bug report. It's always only x.y.z.BUILDNUMBER for the internal version that is used for comparisons.
The versionString displayed to the user can contain anything.
See also #6602

@jnweiger
Copy link
Contributor Author

understand. the BUILDNUMBER works fine. thanks.
but it also only display the build number, when offering an update, no hint if it is a beta or rc, actually.

@guruz
Copy link
Contributor

guruz commented Jul 17, 2018

but it also only display the build number, when offering an update, no hint if it is a beta or rc, actually.

On which platform?
For macOS i had fixed this recently. For Windows it's lacking as per #6602 ...
For Linux you tell me :-)

@ogoffart
Copy link
Contributor

Is this still an issue?

@guruz
Copy link
Contributor

guruz commented Mar 15, 2019

@jnweiger Was the string that you saw one of

    QString updateVersion = _updateInfo.versionString();
...
    case DownloadComplete:
        return tr("%1 available. Restart application to start the update.").arg(Theme::instance()->appNameGUI(), updateVersion);
....
    case UpdateOnlyAvailableThroughSystem:
        return tr("New %1 available. Please use the system's update tool to install it.").arg(updateVersion);

?

Then I would think @ogoffart already fixed it by 21ac396

Please re-open if not

@guruz guruz closed this as completed Mar 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants