Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make a separate object for VFS enabled banner #8867

Closed
swoichha opened this issue Aug 5, 2021 · 4 comments
Closed

make a separate object for VFS enabled banner #8867

swoichha opened this issue Aug 5, 2021 · 4 comments
Labels

Comments

@swoichha
Copy link
Contributor

swoichha commented Aug 5, 2021

Description

While adding tests for VFS(#8651 (comment)) we needed to verify if it was enabled or not using a purple banner with text Virtual file support is enabled.. However, while adding this test we could not find an object for that. It was inside another object as it can be seen in the image below.
Screenshot from 2021-07-26 15-59-58

The element that we want for this test to work does not have a UI file. It is a custom paint job based on model. This make testing a little bit hard.

Possible Solution

For now we have added the test here #8835 and verified the enabling/disabling of VFS using the enable/disable VFS button which is an object names.stack_folderList_QTreeView, "_1" at 718,27. But it would be better if we could get an object for the VFS enabled element.

@TheOneRing
Copy link
Contributor

As I said before the delegate just directly paints the text.
The above screenshot shows me that you get a QModelIndex, you need to access the data() function of that object and query for FolderStatusDelegate::FolderInfoMsg value 362.

Now on how you can get the value from a QModelIndex, no idea but I'm pretty sure squish supports it.

@github-actions
Copy link

github-actions bot commented Sep 5, 2021

This issue was marked stale because it has been open for 30 days with no activity. Remove the stale label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the Stale label Sep 5, 2021
@swoichha swoichha removed the Stale label Sep 6, 2021
@github-actions
Copy link

github-actions bot commented Oct 7, 2021

This issue was marked stale because it has been open for 30 days with no activity. Remove the stale label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the Stale label Oct 7, 2021
@github-actions
Copy link

The issue was marked as stale for 7 days and closed automatically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants