Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[QA] language cannot be switched with the usual environment variables #9534

Closed
jnweiger opened this issue Mar 22, 2022 · 7 comments
Closed

Comments

@jnweiger
Copy link
Contributor

Seen with testpilotcloud-client 2.10.1 rc1

  • start the client, go to settings, switch laguage to 'Deutsch (de)'
  • quit the client.
  • start with LANGUAGE=C LANG=C LC_ALL=C testpilotcloud-client
  • the client comes up again with german UI. BAD
  • other attempts with en, en.UTF-8, en_US also don't work
    image
@gabi18 gabi18 mentioned this issue Mar 22, 2022
55 tasks
@michaelstingl michaelstingl added this to the 2.10.1 milestone Mar 22, 2022
@TheOneRing
Copy link
Contributor

Is there a language explicitly set in the client, on linux the default should be influenced by the env var.
In order to switch the language I'd recommend to use the language switch.

The language switcher was introduced in 2.9 so not a regression.

@TheOneRing TheOneRing removed this from the 2.10.1 milestone Mar 22, 2022
@jnweiger
Copy link
Contributor Author

Yes, language is set to Deutsch in the settings UI

image

Not a regression.

@TheOneRing
Copy link
Contributor

In that case its expected behavior as the users input takes priority over the system language.

@jnweiger
Copy link
Contributor Author

Something in a config file takes priority over user's comand line. That is a step backwards. LC_ALL should be the mighty override for all and any.

@TheOneRing
Copy link
Contributor

When you modify LC_ALL you pretend that the system lang changed. Before you did so, you however changed the language of the client from the system default, which depends on that env var, to German.
If we would now still react to the env, that would be a bug.
However you are not lost and can still set the language from the terminal, see --help.

@jnweiger
Copy link
Contributor Author

jnweiger commented Mar 23, 2022

The current behaviour as seen in testpilotcloud 2.10.1-rc1:

image

When the setting is 'use default', the environment variable LANGUAGE takes control (LANG and(! 😢 ) LC_ALL have no effect)

When the setting is any other language, then also LANGUAGE has no effect.

WORKAROUND:

In any case, the command line option --language takes priority -- even when the UI says (use default). OK.

@TheOneRing
Copy link
Contributor

For the default on linux have a look at https://wiki.qt.io/Locales

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants