Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove version dependen checks and only rely on capabilities #9578

Closed
michaelstingl opened this issue Apr 12, 2022 · 3 comments · Fixed by #9676
Closed

Remove version dependen checks and only rely on capabilities #9578

michaelstingl opened this issue Apr 12, 2022 · 3 comments · Fixed by #9676
Labels
p1-urgent Consider a hotfix release with only that fix (ex: lose trust, money, security issue, ...)
Milestone

Comments

@michaelstingl
Copy link
Contributor

@TheOneRing could you check if this is used?

% curl 'https://demo.owncloud.org/ocs/v1.php/cloud/capabilities?format=json' \
  -u demo:demo | jq '.ocs.data.version'
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  2117  100  2117    0     0   9974      0 --:--:-- --:--:-- --:--:-- 10377
{
  "major": 10,
  "minor": 9,
  "micro": 1,
  "string": "10.9.1",
  "edition": "Community"
}

(not the status.php)

What is expected? What would happen if it changes to this this? owncloud/ocis#2918 (comment)

@TheOneRing
Copy link
Contributor

As far as I can tell we only use the version from status.php .
A version > 10 is expected for some legacy version checks that should be removed anyhow.

@michaelstingl
Copy link
Contributor Author

A version > 10 is expected for some legacy version checks that should be removed anyhow.

Everything > 10 is okay? We could turn it up to 11 and more…?

// Older version which is not "end of life" according to https://github.com/owncloud/core/wiki/Maintenance-and-Release-Schedule
return serverVersionInt() < makeServerVersion(10, 0, 0) || serverVersion().endsWith(QLatin1String("Nextcloud"));

@TheOneRing
Copy link
Contributor

Supposedly

@TheOneRing TheOneRing added this to the 2.11 milestone May 12, 2022
@TheOneRing TheOneRing added the p1-urgent Consider a hotfix release with only that fix (ex: lose trust, money, security issue, ...) label May 12, 2022
@TheOneRing TheOneRing changed the title Does desktop client rely on .ocs.data.version from the capabilities? Remove version dependen checks and only rely on capabilities May 12, 2022
@TheOneRing TheOneRing linked a pull request May 18, 2022 that will close this issue
@HanaGemela HanaGemela moved this to Needs Info in Desktop Testing Oct 28, 2022
@TheOneRing TheOneRing moved this from Needs Info to In Progress in Desktop Testing Nov 4, 2022
@TheOneRing TheOneRing moved this from In Progress to No test needed in Desktop Testing Nov 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p1-urgent Consider a hotfix release with only that fix (ex: lose trust, money, security issue, ...)
Projects
No open projects
Status: No test needed
Development

Successfully merging a pull request may close this issue.

2 participants