Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better handle wrong user error after oauth refresh #9772

Closed
TheOneRing opened this issue Jun 3, 2022 · 4 comments · Fixed by #9813
Closed

Better handle wrong user error after oauth refresh #9772

TheOneRing opened this issue Jun 3, 2022 · 4 comments · Fixed by #9813
Assignees
Labels
p2-high Escalation, on top of current planning, release blocker
Milestone

Comments

@TheOneRing
Copy link
Contributor

Display a proper error instead of an assertion.

@TheOneRing TheOneRing added this to the 3.0 milestone Jun 3, 2022
@TheOneRing TheOneRing self-assigned this Jun 3, 2022
@TheOneRing TheOneRing linked a pull request Jun 22, 2022 that will close this issue
@HanaGemela HanaGemela moved this to Needs Info in Desktop Testing Oct 28, 2022
@HanaGemela
Copy link
Contributor

HanaGemela commented Nov 10, 2022

Steps to recreate

  1. Connect to an oc10 server with oauth2 as Einstein
  2. Log out in the client
  3. Start login process in the client
  4. Open the browser
  5. Log in with Catherine

Test also with ocis

Expected result: Nice error that Logged in with a wrong user

@HanaGemela HanaGemela moved this from Needs Info to Todo in Desktop Testing Nov 10, 2022
@individual-it
Copy link
Member

With ownCloud 10

after logging in with the wrong user in oc10, the site shows this error screen 👍
image

but after logging in again with the correct user the client does not work 👎
image

when using the "retry" button and using the correct user again the client stays in the "OpenBrowser" window 👎
image

The only way is to "Log out" and "Log in" again

logs: ownCloud.log

@michaelstingl michaelstingl added the p2-high Escalation, on top of current planning, release blocker label Nov 21, 2022
@individual-it
Copy link
Member

with ocis

after logging in with the wrong user in ocis the focus changes to the client and this screen is shown 👍
image

clicking on "Retry" brings the user back to
image

"OpenBrowser" brings the user to this screen
image

clicking on "use an other account", logging in with the correct one and allow the connection, shows a "success window" in the browser but the client does not recognize it
image

The only way is to "Log out" and "Log in" again

logs: ownCloud.log

@individual-it individual-it moved this from Todo to In dev in Desktop Testing Nov 21, 2022
@individual-it individual-it removed their assignment Nov 21, 2022
@fmoc
Copy link
Contributor

fmoc commented Nov 21, 2022

Reproducible. We should open a new issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p2-high Escalation, on top of current planning, release blocker
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants